Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools Bug]: can not build react devtools for local development, instructions lead to error #26697

Closed
yanlingwang23 opened this issue Apr 21, 2023 · 10 comments
Closed

[DevTools Bug]: can not build react devtools for local development, instructions lead to error #26697

yanlingwang23 opened this issue Apr 21, 2023 · 10 comments
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug

Comments

@yanlingwang23
Copy link

Website or app

https://github.com/facebook/react/tree/main/packages/react-devtools-extensions

Repro steps

Follow the instructions here to build local version of react devtools extension: https://github.com/facebook/react/tree/main/packages/react-devtools-extensions

git clone https://github.com/facebook/react.git 
cd react
yarn install
yarn build-for-devtools

Stuck on this step everytime yarn build-for-devtools:

D:\Other\react\node_modules\flow-parser\flow_parser.js:807
throw a}function
^

Error: SignedSource.signFile(...): Cannot sign file without token: <<SignedSource::*O*zOeWoEQle#+L!plEphiEmie@IsG>>
    at Object.<anonymous> (D:\Other\react\node_modules\signedsource\index.js:20:28)
    at Module._compile (node:internal/modules/cjs/loader:1196:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1250:10)
    at Module.load (node:internal/modules/cjs/loader:1074:32)
    at Function.Module._load (node:internal/modules/cjs/loader:909:12)
    at Module.require (node:internal/modules/cjs/loader:1098:19)
    at require (node:internal/modules/cjs/helpers:108:18)
    at Object.<anonymous> (D:\Other\react\scripts\rollup\packaging.js:18:37)
    at Module._compile (node:internal/modules/cjs/loader:1196:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1250:10)

Is there anything else I need to set up in order to make this work?

How often does this bug happen?

Every time

DevTools package (automated)

No response

DevTools version (automated)

No response

Error message (automated)

No response

Error call stack (automated)

No response

Error component stack (automated)

No response

GitHub query string (automated)

No response
@yanlingwang23 yanlingwang23 added Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug labels Apr 21, 2023
@markerikson
Copy link
Contributor

markerikson commented Apr 25, 2023 •
edited
Loading

Confirmed, I'm seeing this myself as of #26616 .

I was able to work around it by commenting out the line // processGenerated('build/react-native/shims'); in scripts/rollup/packaging.js, but it's annoying and needs to be fixed.

This was referenced Apr 25, 2023
Merged
Closed
@rubennorte
Copy link
Contributor

Thanks @yanlingwang23 and @markerikson for reporting this issue introduced in #26616. Working on a fix now.

@rubennorte rubennorte mentioned this issue Apr 25, 2023
Merged
rubennorte added a commit that referenced this issue Apr 25, 2023
@rubennorte
Handle line endings correctly on Windows in build script for RN (#26727)
f87e97a 
## Summary

We added some post-processing in the build for RN in #26616 that broke
for users on Windows due to how line endings were handled to the regular
expression to insert some directives in the docblock. This fixes that
problem, reported in #26697 as well.

## How did you test this change?

Verified files are still built correctly on Mac/Linux. Will ask for help
to test on Windows.
@rubennorte
Copy link
Contributor

This should be solve now. Please reopen if you continue seeing issues in "main" after this merge.

github-actions bot pushed a commit that referenced this issue Apr 25, 2023
@josephsavona
Handle line endings correctly on Windows in build script for RN (#26727)
db78d9b 
## Summary

We added some post-processing in the build for RN in #26616 that broke
for users on Windows due to how line endings were handled to the regular
expression to insert some directives in the docblock. This fixes that
problem, reported in #26697 as well.

## How did you test this change?

Verified files are still built correctly on Mac/Linux. Will ask for help
to test on Windows.

DiffTrain build for [f87e97a](f87e97a)
@Biki-das
Copy link
Contributor

Biki-das commented Apr 28, 2023 •
edited
Loading

@rubennorte the devtools extension build still fails i am currently on windows and it's failing for me , i am trying to solve a devtools extension bug which is related to shadowdom and unless i can build the devtools extension that won't be possible!
Windows PowerShell 4_28_2023 5_45_31 PM

@Biki-das
Copy link
Contributor

@yanlingwang23 could you try to build the react devtools extension and see if it builds or not?

@gaearon
Copy link
Collaborator

gaearon commented Apr 28, 2023

@Biki-das This screenshot doesn't show what the actual error is. Can you track it down?

@Biki-das
Copy link
Contributor

Biki-das commented Apr 28, 2023 •
edited
Loading

@Biki-das This screenshot doesn't show what the actual error is. Can you track it down?

Windows PowerShell 4_28_2023 11_33_07 PM
@gaearon this is the error currently I am getting,i have installed the necessary dependencies already as mentioned in the readme!

yarn dev tools build also unable to build some file probably
Windows PowerShell 4_28_2023 11_34_41 PM

@Biki-das
Copy link
Contributor

does this contrib guide still works https://gist.github.com/bvaughn/ae29cafd1290e91cbc4bf6e0be503f8a ? since it's been a long time

@yanlingwang23
Copy link
Author

I'm still having trouble in step yarn build-for-devtools, saw the same issue as @Biki-das
image

@Biki-das
Copy link
Contributor

@gaearon any updates on this one!

EdisonVan pushed a commit to EdisonVan/react that referenced this issue Apr 15, 2024
@rubennorte @AndyPengc12
Handle line endings correctly on Windows in build script for RN (face…
87f7558 
…book#26727)

## Summary

We added some post-processing in the build for RN in facebook#26616 that broke
for users on Windows due to how line endings were handled to the regular
expression to insert some directives in the docblock. This fixes that
problem, reported in facebook#26697 as well.

## How did you test this change?

Verified files are still built correctly on Mac/Linux. Will ask for help
to test on Windows.
bigfootjon pushed a commit that referenced this issue Apr 18, 2024
@rubennorte
Handle line endings correctly on Windows in build script for RN (#26727)
1fb75df 
## Summary

We added some post-processing in the build for RN in #26616 that broke
for users on Windows due to how line endings were handled to the regular
expression to insert some directives in the docblock. This fixes that
problem, reported in #26697 as well.

## How did you test this change?

Verified files are still built correctly on Mac/Linux. Will ask for help
to test on Windows.

DiffTrain build for commit f87e97a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rubennorte @gaearon @markerikson @Biki-das @yanlingwang23