-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<progress> requires value to be an attribute, but it's a property due to inputs #6119
Labels
Comments
This was referenced Feb 25, 2016
This was referenced Mar 10, 2016
Alternatively, I think we could take #5680 which would solve this by virtue of the fact that we can just use attributes everywhere, which makes |
@jimfb As far as I understand the description it does what this issue suggests (to the extent it matters). |
Fixed by #6406 |
sophiebits
changed the title
progress requires value to be an attribute, but it's a property due to inputs
<progress> requires value to be an attribute, but it's a property due to inputs
Aug 1, 2016
gaearon
added a commit
that referenced
this issue
Aug 31, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this issue
Jan 23, 2019
jetoneza
pushed a commit
to jetoneza/react
that referenced
this issue
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that #1510 has landed we still have one final issue to fix (ironically, the initial reason for #1510). #1510 (comment) + #1510 (comment), the problem being that
value
is managed as a property for the purpose of<input>
, but<progress>
requires it to be an attribute so that the attribute is correctly removed when null.As discussed in the second comment, it seems to me that the right approach here is to actually remove all the special property logic from DOMPropertyOperations and instead implement it in the appropriate wrappers instead (ReactDOMInput, etc).
Repro: http://jsfiddle.net/670u7ure/8/
Original issue: #1431
cc @jimfb, @spicyj
The text was updated successfully, but these errors were encountered: