-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ControlList API's controlList attribute #9594
Comments
Just ran into this today as well but inside a stateless/pure component so the ref/lifecycle events really wont work. |
Ran into the same issue today. Support for this (and/or a standardized way to specify unknown props as HTML attributes as described in #7311 etc.) would be awesome. |
@arsduo I'll reference this issue in the description of my PR so that we can be sure to circle back to this issue when it merges. |
Thank you very much!
…On May 22, 2017 18:10, "Nathan Hunzaker" ***@***.***> wrote:
@arsduo <https://github.com/arsduo> I'll reference this issue in the
description of my PR so that we can be sure to circle back to this issue
when it merges.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9594 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC8xd7hb4h-IcLGBmiTPeZYYxiDRCAZks5r8hXFgaJpZM4NPeBB>
.
|
Ran into this issue aswell, would be amazing to have this! |
Seems like it will need adding to these files: |
Ah I might have misdiagnosed this. @rickyH is right, it looks like we just need to add these to a whitelist. I'll throw together a PR and get something up for testing. |
Done in #9940. I've also put up a jsfiddle if anyone doesn't mind taking a gander to make sure I haven't missed something: |
Merged the addition. I've also sent out a pull request to ship it in the next minor release: |
Do we know when this will be released? |
Good question. I just brought it up in the 15.6.2 release umbrella issue (#10040) |
I've put it into the queue for 15.6.2 |
Do you have an estimate for when 15.6.2 will be out? |
This is fixed in 16 and was released in 15.6.2 🎉 |
In version 58, Chrome shipped support for the HTMLMediaElement ControlList API and, by extension, the controlList attribute on elements like
video
andaudio
. Here's how the attribute looks in practice.React <= 15.5.4 does not support this attribute and strips it out with a
Warning: Unknown prop controlsList on <video> tag. Remove this prop from the element.
warning in the console.Could you add support for this new attribute? This isn't a pressing issue as it's possible to set the attribute via javascript (i.e. by setting it in a
ref
or in a component lifecycle event), but it would be nice to have it recognized as the valid attribute it is.The text was updated successfully, but these errors were encountered: