Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Jest with Stack and Fiber as separate projects #10214

Merged
merged 4 commits into from
Jul 19, 2017
Merged

Configure Jest with Stack and Fiber as separate projects #10214

merged 4 commits into from
Jul 19, 2017
+183 −132

Commits on Jul 19, 2017

  1. Disable Fiber specific test run in CI 

    This disables the comparison against previously recorded test. Instead,
we'll rely on jest failures to fail tests.
    @sebmarkbage
    sebmarkbage committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    3c3aa13 View commit details
    Browse the repository at this point in the history

  2. Extract jest config into two separate projects for Fiber and Stack 

    Allows us to run both in the same jest run. The setupMocks file is forked into
specific environment configuration for each project. This replaces the
environment variable.

I used copy pasta here to make it clear. We can abstract this later. It's clear
to me that simply extracting shared stuff is not the best way to abstract this.
setupMocks for example didn't need all the code in both branches.

I think that some of the stuff that is shared such as error message extracting
etc. should probably be lifted out into a stand-alone jest project instead of
being shared.
    @sebmarkbage
    sebmarkbage committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    4f1cdcd View commit details
    Browse the repository at this point in the history

  3. Fix class equivalence test 

    There's a behavior change when projects are used which makes
setupTestFrameworkScriptFile not override the normal config.

This test should probably just move to a separate CI script or something
less hacky.
    @sebmarkbage
    sebmarkbage committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    85b58e7 View commit details
    Browse the repository at this point in the history

  4. Only run Fiber tests with scripts/fiber/record-tests

    @sebmarkbage
    sebmarkbage committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    438212b View commit details
    Browse the repository at this point in the history