Warn when nesting 15 subtree inside 16 #10434

sophiebits · 2017-08-10T23:23:42Z

No description provided.

gaearon · 2017-08-11T04:35:42Z

src/renderers/dom/shared/__tests__/renderSubtreeIntoContainer-test.js

+          'a React 15 tree inside a React 16 tree using ' +
+          "unstable_renderSubtreeIntoContainer, which isn't supported. Try to " +
+          'make sure you have only one copy of React (and ideally, switch to ' +
+          'React.unstable_createPortal).',


It's currently on ReactDOM.

Oh weird. Why? Can amend if that's really intentional.

Intentional because it accepts a DOM node as an argument. Could make one shared around DOM client renderers or SSR compatible that accepts a different argument such as a string query.

sebmarkbage · 2017-08-11T23:04:31Z

Did changing the name of _reactInternalInstance not work out?

sophiebits · 2017-08-11T23:06:43Z

I think we still need a fake _processChildContext method – you'd prefer changing the name _reactInternalInstance and adding a field ._reactInternalInstance = {_processChildContext: throw} on class components?

sebmarkbage · 2017-08-12T00:54:27Z

Yea, I'd prefer that. The possibilities of collision here seems scary.

What happens if we don't add the place holder to class instances?

sophiebits · 2017-08-12T01:20:54Z

I'm not sure what your last question means.

sophiebits

Better?

sophiebits · 2017-08-12T01:26:58Z

src/renderers/shared/fiber/ReactFiberClassComponent.js

@@ -283,6 +305,7 @@ module.exports = function(
    workInProgress.stateNode = instance;
    // The instance needs access to the fiber so that it can schedule updates
    ReactInstanceMap.set(instance, workInProgress);
+    instance._reactInternalInstance = fakeInternalInstance;


Should I make this DEV-only? Seems safer to have it be in prod too. :(

DEV only plz. We stick random stuff on classes all over.

If it's DEV only we at least know that we can remove it at some point. E.g. a minor.

sebmarkbage · 2017-08-12T01:55:50Z

src/renderers/shared/shared/ReactInstanceMap.js

@@ -26,19 +26,19 @@ var ReactInstanceMap = {
   * supported we can rename it.
   */
  remove: function(key) {
-    key._reactInternalInstance = undefined;
+    key._reactInternalInstance16 = undefined;


_reactInternalFiber?

sebmarkbage · 2017-08-12T01:56:16Z

Does this just work with devtools?

flarnie · 2017-08-13T18:29:38Z

src/renderers/shared/fiber/ReactFiberClassComponent.js

+          'a React 15 tree inside a React 16 tree using ' +
+          "unstable_renderSubtreeIntoContainer, which isn't supported. Try " +
+          'to make sure you have only one copy of React (and ideally, switch ' +
+          'to ReactDOM.unstable_createPortal).',


nit - we could condense this and then link to docs, which could provide more info.

I think we could always improve the error message in a follow-up commit, if this comes up often for folks.

flarnie · 2017-08-13T18:35:03Z

Does this just work with devtools?

I'm not sure what that was referring to - it seems like this would work in DEV mode.

lgtm but want to let @sebmarkbage give it a final look if possible.

sophiebits · 2017-08-13T18:37:15Z

The question is whether the devtools relies on _reactInternalInstance. I checked the code last week and am 90% sure this will work but if you want to double check that the dev tools work if you build this and open a fixture, this is good for merge.

…

________________________________ From: Flarnie Marchan <notifications@github.com> Sent: Sunday, August 13, 2017 11:35:06 AM To: facebook/react Cc: Ben Alpert; Author Subject: Re: [facebook/react] Warn when nesting 15 subtree inside 16 (#10434) Does this just work with devtools? I'm not sure what that was referring to - it seems like this would work in DEV mode. lgtm but want to let @sebmarkbage<https://github.com/sebmarkbage> give it a final look if possible. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#10434 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAAapNloBB952FAGiqKLpWDMc2GBo3kUks5sX0HagaJpZM4O0GBD>.

flarnie · 2017-08-13T18:39:04Z

Sounds good - I'll do a quick manual test.

flarnie

I checked out this branch and looked at the dom fixtures with the React devtools, everything works.

gaearon · 2017-08-14T15:46:45Z

src/renderers/shared/shared/ReactInstanceMap.js

@@ -26,19 +26,19 @@ var ReactInstanceMap = {
   * supported we can rename it.
   */
  remove: function(key) {
-    key._reactInternalInstance = undefined;
+    key._reactInternalFiber = undefined;


This will break hot reloading (which we just fixed). Do you mind sending a PR to react-deep-force-update to account for this change? Should be as easy as checking both fields.

facebook-github-bot added the CLA Signed label Aug 10, 2017

gaearon mentioned this pull request Aug 11, 2017

React 16 Umbrella ☂️ (and 15.5) #8854

Closed

sophiebits requested review from sebmarkbage and acdlite August 11, 2017 00:55

gaearon reviewed Aug 11, 2017

View reviewed changes

sophiebits force-pushed the pcc-15-16 branch from b5bea2a to 4e42318 Compare August 11, 2017 22:28

sophiebits force-pushed the pcc-15-16 branch from 4e42318 to 670726d Compare August 12, 2017 01:26

sophiebits commented Aug 12, 2017

View reviewed changes

sebmarkbage reviewed Aug 12, 2017

View reviewed changes

Warn when nesting 15 subtree inside 16

3833659

sophiebits force-pushed the pcc-15-16 branch from 670726d to 3833659 Compare August 12, 2017 02:28

flarnie reviewed Aug 13, 2017

View reviewed changes

flarnie approved these changes Aug 13, 2017

View reviewed changes

sophiebits merged commit 9921e57 into facebook:master Aug 13, 2017

gaearon reviewed Aug 14, 2017

View reviewed changes

bvaughn mentioned this pull request Sep 7, 2017

React 16 RC #10294

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warn when nesting 15 subtree inside 16 #10434

Warn when nesting 15 subtree inside 16 #10434

sophiebits commented Aug 10, 2017

gaearon Aug 11, 2017

sophiebits Aug 11, 2017

sebmarkbage Aug 11, 2017

sebmarkbage commented Aug 11, 2017

sophiebits commented Aug 11, 2017

sebmarkbage commented Aug 12, 2017

sophiebits commented Aug 12, 2017

sophiebits left a comment

sophiebits Aug 12, 2017

sebmarkbage Aug 12, 2017

sebmarkbage Aug 12, 2017

sebmarkbage Aug 12, 2017

sebmarkbage commented Aug 12, 2017

flarnie Aug 13, 2017

flarnie commented Aug 13, 2017

sophiebits commented Aug 13, 2017 via email

flarnie commented Aug 13, 2017

flarnie left a comment

gaearon Aug 14, 2017

Warn when nesting 15 subtree inside 16 #10434

Warn when nesting 15 subtree inside 16 #10434

Conversation

sophiebits commented Aug 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebmarkbage commented Aug 11, 2017

sophiebits commented Aug 11, 2017

sebmarkbage commented Aug 12, 2017

sophiebits commented Aug 12, 2017

sophiebits left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebmarkbage commented Aug 12, 2017

Choose a reason for hiding this comment

flarnie commented Aug 13, 2017

sophiebits commented Aug 13, 2017 via email

flarnie commented Aug 13, 2017

flarnie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment