Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10443 #10448

Merged
merged 1 commit into from
Aug 12, 2017
Merged

Fixes #10443 #10448

merged 1 commit into from
Aug 12, 2017

Conversation

fxfactorial
Copy link
Contributor

No description provided.

acdlite
acdlite requested changes Aug 12, 2017
View reviewed changes
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you run yarn prettier and commit the result.

src/renderers/native/findNodeHandle.js Outdated
@@ -16,7 +16,7 @@ var ReactInstanceMap = require('ReactInstanceMap');
var ReactNativeFeatureFlags = require('ReactNativeFeatureFlags');
var ReactNativeFiberRenderer = require('ReactNativeFiberRenderer');
var {ReactCurrentOwner} = require('ReactGlobalSharedState');

var getComponentName = require('getComponentName.js');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the .js extension

src/renderers/native/findNodeHandle.js Outdated
@@ -76,7 +76,7 @@ function findNodeHandle(componentOrHandle: any): any {
'never access something that requires stale data from the previous ' +
'render, such as refs. Move this logic to componentDidMount and ' +
'componentDidUpdate instead.',
owner.getName() || 'A component',
getComponentName(owner)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

getComponentName(owner) || 'A component',

@fxfactorial
Copy link
Contributor Author

fxfactorial commented Aug 12, 2017 •
edited
Loading

@acdlite Done, I forgot that FB prefers trailing ,, force pushed

@fxfactorial
Copy link
Contributor Author

@acdlite I think that should cover it.

@acdlite acdlite merged commit 2cd0ecd into facebook:master Aug 12, 2017
@acdlite
Copy link
Collaborator

acdlite commented Aug 12, 2017

Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Aug 23, 2017

This is not enough to fix the issue. Please see #10518.

@gaearon gaearon mentioned this pull request Aug 23, 2017
Closed
@bvaughn bvaughn mentioned this pull request Sep 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite requested changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fxfactorial @acdlite @gaearon @facebook-github-bot