Add explicit invariant when ReactDOM is loaded without React #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweary
commented
Aug 12, 2017
| invariant( | ||
| require('react'), | ||
| 'ReactDOM was loaded without React. Make sure you load ' + | ||
| 'the React package before loading ReactDOM.', |
There was a problem hiding this comment.
I'm not a big fan of this copy, I'm open to suggestions 😄
There was a problem hiding this comment.
Maybe "ReactDOM was loaded before React."
There was a problem hiding this comment.
The other sentence looks good to me.
gaearon
approved these changes
Aug 13, 2017
| var invariant = require('fbjs/lib/invariant'); | ||
|
|
||
| invariant( | ||
| require('react'), |
There was a problem hiding this comment.
Let's extract this to a variable to be consistent.
| invariant( | ||
| require('react'), | ||
| 'ReactDOM was loaded without React. Make sure you load ' + | ||
| 'the React package before loading ReactDOM.', |
There was a problem hiding this comment.
Maybe "ReactDOM was loaded before React."
| invariant( | ||
| require('react'), | ||
| 'ReactDOM was loaded without React. Make sure you load ' + | ||
| 'the React package before loading ReactDOM.', |
There was a problem hiding this comment.
The other sentence looks good to me.
aweary
force-pushed
the
warn-react-dom-no-react
branch
from
fb194b5
to
7c2891b
Compare
aweary
force-pushed
the
warn-react-dom-no-react
branch
from
7c2891b
to
7da3a63
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10406