Fix context memory leak #10680
Merged
Fix context memory leak #10680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested review from
bvaughn,
sebmarkbage and
acdlite
and removed request for
bvaughn and
acdlite
|
Got confirmation this actually fixes the leak in Marketplace. |
|
If I understand correctly, 21712891. |
sebmarkbage
approved these changes
Sep 12, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we always pop the root context. Fixes a memory leak when
unmountComponentAtNode()leaves reference to the tree via the context stack.Verified by putting a breakpoint in
unmountComponentAtNodeand checking the context stack (which is nownulled).