Fix "null" instead of the component stack in a warning #10915
Merged
+72
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are so many places this gets reset. I have no confidence in whether this was needed or not and how it's supposed to work. 😕 |
|
Are there other cases this could be |
It should only be reset when we stop doing work. Otherwise, any warnings after the reset will lose the component stack. The reset in getMaskedContext() was completely unnecessary. It is always called with the same fiber as the current work in progress. Therefore, I add a DEV-only warning assertion to ensure we don't regress, and remove the reset. The reset in processChildContext() is necessary because it can be called outside of reconciliation. Unfortunately, we have to keep this hack in until we can remove unstable_renderSubtreeIntoContainer(). To work around it, I restore the previous fiber instead of resetting.
gaearon
force-pushed
the
fix-null-stack
branch
from
fe3831a to
4f5a5f8
Compare
|
Okay, I can restructure it a bit to make it clearer. I think it's actually not complicated, but the |
sebmarkbage
approved these changes
Sep 28, 2017
|
Why don't you just trust me, Sebastian |
|
Deploy preview failed. Built with commit 3afc7b4 https://app.netlify.com/sites/reactjs/deploys/59cd4c7cdf995340c19c37fa |
These are two distinct actions. This helps make it clearer when we're actually changing the current pointer. I'm also removing an overengineered hack I previously added for unstable_renderSubtreeIntoContainer. It's not necessary now that we don't null the pointer all the time. This makes the code more straightforward.
gaearon
force-pushed
the
fix-null-stack
branch
from
2c83514 to
cd91454
Compare
gaearon
force-pushed
the
fix-null-stack
branch
from
cd91454 to
3afc7b4
Compare
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
This was referenced Feb 2, 2018
This was referenced Mar 1, 2018
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10831.
(Note: the warning itself is still legit. This just fixes it to print the component stack instead of
nullin some cases.)See individual commit messages for more info on what we did wrong and why this helps.