Adjacent text nodes in SSR should have comments between them despite components #11109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we don't reset it when we exit components that return strings.
This fixes the {'a'}</div>{'b'} case and prevents an unnecessary comment before 'b'.
|
Deploy preview ready! Built with commit cd2df6c |
sebmarkbage
reviewed
Oct 9, 2017
| @@ -827,6 +830,7 @@ class ReactDOMServerRenderer { | |||
| frame.debugElementStack = []; | |||
| } | |||
| this.stack.push(frame); | |||
| this.previousWasTextNode = false; | |||
There was a problem hiding this comment.
So is this unnecessary now? Seems like the fix was the second commit, not this, no?
There was a problem hiding this comment.
If I remember it right I tried commenting both places out separately after adding the tests, and both were necessary. This one resets when we're entering a tag, and another resets when we're leaving a tag.
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
This was referenced Feb 2, 2018
Open
This was referenced Feb 2, 2018
This was referenced Mar 1, 2018
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10598.
See individual commits and test cases I added.