Add production bundles for Test and Shallow renderers #11112
Conversation
| } else { | ||
| module.exports = require('./cjs/react-test-renderer.development'); | ||
| module.exports = require('./cjs/react-test-renderer.development.js'); |
There was a problem hiding this comment.
For consistency with other packages.
gaearon
force-pushed
the
prod-test-bundles
branch
from
0bb7e22
to
4206017
Compare
|
Deploy preview failed. Built with commit 97fd6b7 https://app.netlify.com/sites/reactjs/deploys/59d63ca7a6188f17e537fd83 |
|
Deploy preview ready! Built with commit 4206017 |
|
Do you guys have a rough idea of when the build including this change is going to be released ? |
|
Bump for the question above. Or at least some suggested workaround that makes it possible to use React v16 in production with the current release. |
|
Probably next week. The workaround is, as always, build from master if you depend on something that's only in master. I'm not sure what you expect. If this is blocking you from upgrading to 16, can you just not update to it yet? This has not been working in 16.0.0 so it's not like we broke this in a patch release either. We can't just do releases as soon as PRs are merged. We need to ensure the release is solid and works well. We've found other bugs during internal testing, and need to do another round of testing this week. If it goes well then we'll release next week. If not then a week later. In general it is not very productive to pressure us into releasing things faster. We have the same goals as you and also want to get them out soon. But if we hurry too much we will break your code, so with the number of dependents we want to be extra cautious and I hope you appreciate this. |
|
Hey @gaearon, thanks for the response! I'm really sorry that my message sounded like I was putting pressure on you, that wasn't my goal. I only wanted to have a rough estimate, so I could prioritize things in our project. And yes, I definitely appreciate that, was having a conversation with a colleague about that just a moment ago - how it's nice that since I started using React two years and a half ago, it never broke any of my projects after an upgrade. So, thank you for that :) |
|
Thanks! Sorry if I sounded too defensive. For context we've already been hoping to release this two times, but each time found show stopper bugs that triggered another round of re-testing and fixes. So I can’t give an exact estimate better than “within a couple of weeks” or “when it’s solid” 🙂 |
|
For everyone watching this pull request, allow me to send a notification to your inboxes! Thanks for this change, now I don't have to override NODE_ENV for a single command on our CI anymore :-) |
* Add production bundles for Test and Shallow renderers * Remove unused/broken file from test renderer * Add production bundle for TestUtils
Per discussion in #10938, adds bundles for production versions of test and shallow renderer.
Tested by building and running Node REPL with
productionenv and doing a basic sanity check.