-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect calculation of onMouseEnter/Leave component path #11164
Conversation
This will be easier to follow when we add more code there.
So that I can add a block scoped variable.
This is the actual bugfix.
420b58a
to
ef6d6fc
Compare
while (from && from !== common) { | ||
const common = from && to ? getLowestCommonAncestor(from, to) : null; | ||
const pathFrom = []; | ||
while (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to avoid while (true)
since (at least in older versions) it has been known to deopt.
I appreciate the rewrite for the temp variable and easy of read. But arguably this just make the condition seem a lot more complicated than it really is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't it deopt when you have continue
s rather than break
? I don't remember. @trueadm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think I prefer the other writing style, even if that includes a temporary variable assignment inline in the condition.
Like this? while (from && from !== common && (!from.alternate && from.alternate !== common)) { I'm not sure how else to write it in a single line. I’m finding this really hard to follow, especially because the |
Or, rather, while (from && from !== common && (!from.alternate || from.alternate !== common)) { See, I already made a mistake there. 😛 |
Do you like this? while (from && (!common || (from !== common && from.alternate !== common))) { If we check for |
Meh. I find all of these hard to follow and I don't know if they're correct. |
Fixes #10906 and #11152.
We forgot to compare alternates so in some cases, the from/to path was calculated incorrectly.
See individual commits. The first one adds a test, the last one fixes the bug. The ones in the middle prepare the code to look readable after the bugfix.
I verified both #10906 and #11152 reproduced before, but no longer reproduce after the bugfix.