Matches like performance improvement #11215
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
This looks good to me. Great catch!
It would be awesome to add Flow to these files to catch simple stuff like this. I don't think that it has to/should happen in this PR, but @gaearon do you know if there's an existing strategy for "flowifying" React?
|
No specific strategy but we always welcome patches that improve Flow coverage. |
According to https://github.com/facebook/react/blob/master/src/renderers/dom/shared/dangerousStyleValue.js#L25
styleValue is already string.