Accept React attributes on custom components #11217
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
It seems that currently if you pass a React attribute to a custom component, it doesn't replace it with the html counterpart but just renders it as text.
For example:
<amp-img className="my-image" />
will render<amp-img classname="my-image" />
.Apparently, that's by design, since we found that there are tests explicitly checking this behaviour.
Do you really think that this should work the way it is? It feels a bit strange that for custom components you would need to use
class
instead ofclassName
.(thanks @jacksbox for the pairing session 😃)
Cheers