Use const/let in more places #11467
Merged
Use const/let in more places #11467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raphamorim
commented
Nov 6, 2017
•
raphamorim
commented
- Convert ReactDOM to const/let
- Convert ReactDOMComponentTree to const/let
- Convert ReactDOMComponentTree to const/let
- Convert getNodeForCharacterOffset to const/let
- Convert getTextContentAccessor to const/let
- Convert inputValueTracking to const/let
- Convert setInnerHTML to const/let
- Convert setTextContent to const/let
- Convert validateDOMNesting to const/let
odykyi
approved these changes
Nov 6, 2017
gaearon
reviewed
Nov 6, 2017
| // IE does not have innerHTML for SVG nodes, so instead we inject the | ||
| // new markup in a temp node and then move the child nodes across into | ||
| // the target node | ||
|
|
||
| // SVG temp container for IE lacking innerHTML | ||
| let reusableSVGContainer; |
There was a problem hiding this comment.
It is intentionally outside of the function. We don't want to allocate one per call.
There was a problem hiding this comment.
Make sense. Updated ad3223a
* Convert ReactDOM to const/let * Convert ReactDOMComponentTree to const/let * Convert ReactDOMComponentTree to const/let * Convert getNodeForCharacterOffset to const/let * Convert getTextContentAccessor to const/let * Convert inputValueTracking to const/let * Convert setInnerHTML to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let
gaearon
approved these changes
Nov 6, 2017
|
Thanks. |
raphamorim
added a commit
to raphamorim/react
that referenced
this pull request
Nov 12, 2017
* Convert ReactDOMFiberTextarea to const/let * Convert ReactDOMSelection to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let
raphamorim
added a commit
to raphamorim/react
that referenced
this pull request
Nov 12, 2017
raphamorim
added a commit
to raphamorim/react
that referenced
this pull request
Nov 12, 2017
raphamorim
added a commit
to raphamorim/react
that referenced
this pull request
Nov 12, 2017
* Convert ReactDOMFiberTextarea to const/let * Convert ReactDOMSelection to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let
raphamorim
added a commit
to raphamorim/react
that referenced
this pull request
Nov 13, 2017
* Convert ReactDOMFiberTextarea to const/let * Convert ReactDOMSelection to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let
gaearon
pushed a commit
that referenced
this pull request
Nov 19, 2017
* Use const/let in more places (#11467) * Convert ReactDOMFiberTextarea to const/let * Convert ReactDOMSelection to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let * Replace Object.assign by Object Spread * Convert ReactDOMFiberOption to Object Spread * Convert ReactDOMFiberTextarea to Object Spread * Convert validateDOMNesting to Object Spread
raphamorim
added a commit
to raphamorim/react
that referenced
this pull request
Nov 23, 2017
* Convert BeforeInputEventPlugin to const/let * Convert BrowserEventConstats to const/let * Convert ChangeEventPlugin to const/let * Convert DOMEventPluginOrder to const/let * Convert EnterLeaveEventPlugin to const/let * Convert FallbackCompositionState to const/let * Convert getEventCharCode to const/let * Convert getEventKey to const/let
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Convert ReactDOM to const/let * Convert ReactDOMComponentTree to const/let * Convert ReactDOMComponentTree to const/let * Convert getNodeForCharacterOffset to const/let * Convert getTextContentAccessor to const/let * Convert inputValueTracking to const/let * Convert setInnerHTML to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Use const/let in more places (facebook#11467) * Convert ReactDOMFiberTextarea to const/let * Convert ReactDOMSelection to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let * Replace Object.assign by Object Spread * Convert ReactDOMFiberOption to Object Spread * Convert ReactDOMFiberTextarea to Object Spread * Convert validateDOMNesting to Object Spread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.