Added tests for getEventTarget #11528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a unit test, which we're trying to avoid. It won't help us if we rewrite the implementation and stop using this helper. Instead we want to have integration tests using public API only. |
|
Makes sense. Are we thinking about a strategy on how we integration test cross browser inconsistencies? For example having |
|
The tests I previously pointed to (#11365) already do this 🙂 please check them out. |
|
Alright. I'm gonna close this. Will keep an eye on the migration to public API test. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getEventTargetseemed not to have been tested yet. This PR adds some tests for it.