Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite ReactTreeTraversal-test.js using public APIs #11664

Merged
merged 10 commits into from
Nov 29, 2017
Merged

Rewrite ReactTreeTraversal-test.js using public APIs #11664

merged 10 commits into from
Nov 29, 2017

Commits on Nov 26, 2017

  1. rewrite two phase traversal tests with public APIs

    @timjacobi
    timjacobi committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    324641f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. rewrite enter/leave tests

    @timjacobi
    timjacobi committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    c186e01 View commit details
    Browse the repository at this point in the history

  2. lift render into beforeEach, organise variables

    @timjacobi
    timjacobi committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    e889dc4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2017

  1. move getLowestCommonAncestor test

    @timjacobi
    timjacobi committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    c96f658 View commit details
    Browse the repository at this point in the history

  2. remove internal tree traversal test

    @timjacobi
    timjacobi committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    7c47c07 View commit details
    Browse the repository at this point in the history

  3. fix linter errors

    @timjacobi
    timjacobi committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    185e5e0 View commit details
    Browse the repository at this point in the history

  4. move creation of outer nodes into {before,after}Each

    @timjacobi
    timjacobi committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    2847074 View commit details
    Browse the repository at this point in the history

  5. explain why getLowestCommonAncestor test was moved

    @timjacobi
    timjacobi committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    5f7bcd2 View commit details
    Browse the repository at this point in the history

  6. remove unnessecary ARG and ARG2 token 

    these were used for testing the internal API to simulate synthetic
events passed to traverseEnterLeave. since we're now dealing with
actual synthetic events we can remove them.
    @timjacobi
    timjacobi committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    ee2992e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2017

  1. run prettier

    @timjacobi
    timjacobi committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    fab27fb View commit details
    Browse the repository at this point in the history