Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidateDOMNesting tests(#11299) #11742

Merged
merged 4 commits into from
Dec 7, 2017
Merged

ValidateDOMNesting tests(#11299) #11742

merged 4 commits into from
Dec 7, 2017

Commits on Dec 7, 2017

  1. ValidateDOMNesting tests(facebook#11299) 

     * Rewrite tests using only public API.
 * Modified the tests to prevent duplication of code.
 * Code review changes implemented.
 * Removed the .internal from the test file name as
   its now written using public APIs.
    @imanushree
    imanushree committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    90eda25 View commit details
    Browse the repository at this point in the history

  2. Remove mutation

    @gaearon
    gaearon authored Dec 7, 2017
    Configuration menu
    Copy the full SHA
    25f9199 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary argument 

    Now that we pass warnings, we don't need to pass a boolean.
    @gaearon
    gaearon authored Dec 7, 2017
    Configuration menu
    Copy the full SHA
    834a162 View commit details
    Browse the repository at this point in the history

  4. Move things around a bit, and add component stack assertions

    @gaearon
    gaearon authored Dec 7, 2017
    Configuration menu
    Copy the full SHA
    3be5a2e View commit details
    Browse the repository at this point in the history