Improve toWarnDev matcher DX for unexpected warnings #12082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use jest-diff to format the warnings in a way that makes it easier to spot the differences.
bvaughn
force-pushed
the
improve-unexpected-warning-diff-for-toWarnDev
branch
from
903a4c8
to
45e82b0
Compare
gaearon
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
jest-diffto format the warnings in a way that makes it easier to spot the differences.Before
The differences before are hard to spot!
After
One unmatched expectation
If there's a single unmatched expectation, then just diff the individual strings:
Multiple unmatched expectations
Wrap in an array and do a diff. Let Jest decide which of the inner strings is closest. In some cases the diff might not be useful (if the warning was a completely different one than you were expecting) but in other cases the output can be meaningful:
No remaining expected warnings
Just print the unexpected warning by itself:
