Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record "actual" times for all Fibers within a Profiler tree (alt) #12910

Merged
merged 8 commits into from
May 25, 2018
Merged

Record "actual" times for all Fibers within a Profiler tree (alt) #12910

merged 8 commits into from
May 25, 2018

Commits on May 25, 2018

  1. Moved actual time fields from Profiler stateNode to Fiber

    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    2aa7da1 View commit details
    Browse the repository at this point in the history

  2. Record actual time for all Fibers within a ProfileMode tree

    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    5005f08 View commit details
    Browse the repository at this point in the history

  3. Reset actualDuration for all Fibers (not just Profilers)

    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    b66a44a View commit details
    Browse the repository at this point in the history

  4. Add commit batch ID to Profiler 

    A global 'batch id' is updated during the commit phase. Each (profiled) Fiber has a local batch id.

When the Profiler timer is started- the local id is compared to the global one in order to determine whether to reset or accumulate duration.

This has the downside of adding an additional field to fibers (for profiling builds only) but the upside of containing the writes to 'render' phase and allowing the DevTools commit hook to run before durations have been cleared out (so it can read them for profiling mode).
    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    6473dd6 View commit details
    Browse the repository at this point in the history

  5. Reverted unnecessary change to ReactFiberCommitWork

    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    3c03bb3 View commit details
    Browse the repository at this point in the history

  6. Fixed an invalid test flush-through id

    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    05fa464 View commit details
    Browse the repository at this point in the history

  7. Changed how profiler accumulates time 

    This change gives up on accumulating time across renders of different priority, but in exchange- simplifies how the commit phase (reset) code works, and perhaps also makes the profiling code more compatible with future resuming behavior
    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    a3318ec View commit details
    Browse the repository at this point in the history

  8. Moved duration reset into createWorkInProgress() else block

    Brian Vaughn committed May 25, 2018
    Configuration menu
    Copy the full SHA
    edc7a5d View commit details
    Browse the repository at this point in the history