Fallback to event.srcElement for IE9 #12976

nhunzaker · 2018-06-04T11:16:48Z

It looks like we accidentally removed a fallback condition for the event target in IE9 when we dropped some support for IE8. This commit adds the event target specific support code back to getEventTarget.js

Fixes #12506

Test Plan

Open IE9
Visit http://react-nh-fix-ie9-target.surge.sh/number-inputs
Try to enter text into the inputs

Local Behavior: Includes this fix. event.target falls back to event.srcElement and text correctly updates
16.4.0 Behavior: Text does not update because event.target.value references the window, which is always undefined.

http://react-nh-fix-ie9-target.surge.sh/number-inputs?version=16.4.0

Note: It's a bummer that IE9 can't fetch our latest tags... I'll try to do something about that.

nhunzaker · 2018-06-04T11:26:19Z

Grr. Looks like CI got garbled on Danger.

nhunzaker · 2018-06-04T11:29:34Z

packages/react-dom/src/events/getEventTarget.js

-  let target = nativeEvent.target || window;
+  // Fallback to nativeEvent.srcElement for IE9
+  // https://github.com/facebook/react/issues/12506
+  let target = nativeEvent.target || nativeEvent.srcElement || window;


Should we have an internal unit test for this?

I'd really like to track down the reason for this so we don't accidentally remove it again as well. Everything I can find suggests that srcElement should not be needed in IE9, so I'm wondering where the issue is coming from. I haven't found much some-places suggest that when attachEvent is used it follows the ie8 event model (with target undefined), I wonder if some branches are still hitting attachEvent?

the change polyfill uses it, Perhaps that's the root cause? I think we could use addEventListener there...

Interesting... I actually remove that listener in #12505. I'll hunt!

My other guess is that maybe it's like a quirksmode sort of thing, where folks are seeing something in document mode they don't realize they are in, in ie9 :/

nhunzaker · 2018-06-04T21:13:12Z

@jquense I bow to your mastery of the DOM. Using addEventListener addressed the issue as well obviated my PR to fix undo in IE9 (#12505).

nhunzaker · 2018-06-04T21:14:47Z

Well actually... 🤦‍♂️ I didn't update the event listener name when I went to addEventListener. Here we go again...

nhunzaker · 2018-06-04T21:24:51Z

@jquense looks like propertychange only fires if you assign input.onpropertychange or use attachEvent.

Still: the false positive suggests that there's something goofy going on here. I'll investigate why the onpropertychange handler appears not to be necessary (also demonstrated in #12505).

jquense · 2018-06-04T23:14:08Z

I was afraid it'd all coming tumbling down if we moved one piece :p I can try and take a closer look as well a bit later if it helps at all

aweary · 2018-06-05T00:07:19Z

If we get rid of onpropertychange in #12505 then we shouldn't need this fix right?

nhunzaker · 2018-06-05T00:09:22Z

@aweary Correct. This is just temporarily addresses the event target issue in IE9 until we can figure out if onpropertychange can go.

gaearon · 2018-06-05T16:54:44Z

It wasn't accidental, I removed it in #11515 because I thought it's IE8-only. Sorry.

nhunzaker · 2018-06-05T17:13:40Z

@gaearon we also approved it :D. It looks like we need this as long as we use onpropertychange, which emits an MSEventObject circa IE8.

It sounds like (from #12505) removing onpropertychange is going to be a can of worms. I don't know when the next patch release is, but it would be cool to get this out in the next patch, if we can.

CI is failing because of danger. Is there a way to fix that?

gaearon · 2018-06-05T17:24:58Z

Does rebasing help?

It looks like we accidentally removed a fallback condition for the event target in IE9 when we dropped some support for IE8. This commit adds the event target specific support code back to getEventTarget.js Fixes facebook#12506

aweary · 2018-06-05T17:38:25Z

Fixing this for IE9 is pretty low priority (it's been broken for a long time and nobody reported it), so it may be worth spending more time on a better solution if we think we can find one.

nhunzaker · 2018-06-05T17:40:34Z

@gaearon sure enough.

nhunzaker · 2018-06-05T18:53:25Z

@aweary This isn't much of a change to revert if we sort that out, but I think it's probably fine if we want to just worry about what to do with onpropertychange.

See: facebook@6066f49

gaearon · 2018-06-11T13:36:02Z

Let's just get this in for now, it's a simple fix and now has a GH issue link.
Happy to merge a more comprehensive solution later.

193: Update dependency react to v16.4.1 r=magopian a=renovate[bot] This Pull Request updates dependency [react](https://github.com/facebook/react) from `v16.4.0` to `v16.4.1` <details> <summary>Release Notes</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@bvaughn] in [#12911](`https://github.com/facebook/react/pull/12911`)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@spirosikmd] in [#12135](`https://github.com/facebook/react/pull/12135`)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@ThaddeusJiang] in [#12996](`https://github.com/facebook/react/pull/12996`)) * Fix a range input not updating in some cases. ([@Illu] in [#12939](`https://github.com/facebook/react/pull/12939`)) * Fix input validation triggering unnecessarily in Firefox. ([@nhunzaker] in [#12925](`https://github.com/facebook/react/pull/12925`)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@nhunzaker] in [#12976](`https://github.com/facebook/react/pull/12976`)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@philipp-spiess] in [#12966](`https://github.com/facebook/react/pull/12966`)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@ericsoderberghp] in [#12985](`https://github.com/facebook/react/pull/12985`), [@gaearon] in [#13019](`https://github.com/facebook/react/pull/13019`)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@gaearon] in [#13017](`https://github.com/facebook/react/pull/13017`)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@fatfisz] in [#13030](`https://github.com/facebook/react/pull/13030`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>

25: Update react monorepo to v16.4.1 r=renovate[bot] a=renovate[bot] This Pull Request renovates the package group "react monorepo". - [react-dom](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` - [react](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` # Release Notes <details> <summary>facebook/react</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@bvaughn] in [#12911](`https://github.com/facebook/react/pull/12911`)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@spirosikmd] in [#12135](`https://github.com/facebook/react/pull/12135`)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@ThaddeusJiang] in [#12996](`https://github.com/facebook/react/pull/12996`)) * Fix a range input not updating in some cases. ([@Illu] in [#12939](`https://github.com/facebook/react/pull/12939`)) * Fix input validation triggering unnecessarily in Firefox. ([@nhunzaker] in [#12925](`https://github.com/facebook/react/pull/12925`)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@nhunzaker] in [#12976](`https://github.com/facebook/react/pull/12976`)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@philipp-spiess] in [#12966](`https://github.com/facebook/react/pull/12966`)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@ericsoderberghp] in [#12985](`https://github.com/facebook/react/pull/12985`), [@gaearon] in [#13019](`https://github.com/facebook/react/pull/13019`)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@gaearon] in [#13017](`https://github.com/facebook/react/pull/13017`)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@fatfisz] in [#13030](`https://github.com/facebook/react/pull/13030`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>

facebook-github-bot added the CLA Signed label Jun 4, 2018

nhunzaker requested a review from aweary June 4, 2018 11:28

nhunzaker commented Jun 4, 2018

View reviewed changes

nhunzaker mentioned this pull request Jun 4, 2018

Fix IE9 Undo Bug #12505

Closed

nhunzaker force-pushed the nh-fix-ie9-target branch from 7c3d3ac to fcc3c89 Compare June 4, 2018 21:43

Fallback to event.srcElement for IE9

6066f49

It looks like we accidentally removed a fallback condition for the event target in IE9 when we dropped some support for IE8. This commit adds the event target specific support code back to getEventTarget.js Fixes facebook#12506

nhunzaker force-pushed the nh-fix-ie9-target branch from fcc3c89 to 6066f49 Compare June 5, 2018 17:29

joshd-infotrack added a commit to joshd-infotrack/react that referenced this pull request Jun 7, 2018

Fallback to event.srcElement for IE9 facebook#12976

16ffe15

See: facebook@6066f49

gaearon merged commit 4ac6f13 into facebook:master Jun 11, 2018

afc163 mentioned this pull request Jun 14, 2018

input doesn't work with FieldDecorator in IE9 ant-design/ant-design#10109

Closed

1 task

dependencies bot mentioned this pull request Oct 1, 2018

Update react-dom in /modules/frontend from 16.3.0 to 16.5.2 project-accelerate/accelerate#277

Open

This was referenced Nov 1, 2018

Update react-dom in / from 16.2.0 to 16.6.0 leonardofaria/leozera-ui#253

Closed

Update react in / from 16.2.0 to 16.6.0 leonardofaria/leozera-ui#254

Closed

This was referenced Dec 1, 2018

Update react-test-renderer in /modules/frontend from 16.3.0 to 16.6.3 project-accelerate/accelerate#312

Open

Update react in /modules/frontend from 16.3.0 to 16.6.3 project-accelerate/accelerate#313

Open

This was referenced Mar 15, 2021

chore(deps): bump react-dom from 16.4.0 to 16.4.2 in /intro-react-v5 samuelsilvadev/front-end-master-courses#9

Merged

Bump react-dom from 16.4.0 to 16.4.2 in /client cdhenry/pivot#1

Open

This was referenced Sep 5, 2024

[Snyk] Fix for 104 vulnerabilities Omrisnyk/lock-walker#65

Open

[Snyk] Fix for 104 vulnerabilities Omrisnyk/lock-walker#66

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fallback to event.srcElement for IE9 #12976

Fallback to event.srcElement for IE9 #12976

nhunzaker commented Jun 4, 2018 •

edited

Loading

nhunzaker commented Jun 4, 2018

nhunzaker Jun 4, 2018

jquense Jun 4, 2018

jquense Jun 4, 2018

nhunzaker Jun 4, 2018

jquense Jun 4, 2018

nhunzaker commented Jun 4, 2018

nhunzaker commented Jun 4, 2018

nhunzaker commented Jun 4, 2018

jquense commented Jun 4, 2018

aweary commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

gaearon commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

gaearon commented Jun 5, 2018

aweary commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

gaearon commented Jun 11, 2018

Fallback to event.srcElement for IE9 #12976

Fallback to event.srcElement for IE9 #12976

Conversation

nhunzaker commented Jun 4, 2018 • edited Loading

nhunzaker commented Jun 4, 2018

nhunzaker Jun 4, 2018

Choose a reason for hiding this comment

jquense Jun 4, 2018

Choose a reason for hiding this comment

jquense Jun 4, 2018

Choose a reason for hiding this comment

nhunzaker Jun 4, 2018

Choose a reason for hiding this comment

jquense Jun 4, 2018

Choose a reason for hiding this comment

nhunzaker commented Jun 4, 2018

nhunzaker commented Jun 4, 2018

nhunzaker commented Jun 4, 2018

jquense commented Jun 4, 2018

aweary commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

gaearon commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

gaearon commented Jun 5, 2018

aweary commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

nhunzaker commented Jun 5, 2018

gaearon commented Jun 11, 2018

nhunzaker commented Jun 4, 2018 •

edited

Loading