Fix an SVG focusing crash in IE11 #12996

ThaddeusJiang · 2018-06-08T02:31:19Z

facebook-github-bot · 2018-06-08T02:31:34Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2018-06-08T02:39:50Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

gaearon · 2018-06-08T12:17:09Z

packages/react-dom/src/client/ReactInputSelection.js

@@ -82,7 +83,7 @@ export function restoreSelection(priorSelectionInformation) {
      }
    }

-    priorFocusedElem.focus();
+    focusNode(priorFocusedElem);


Let’s just inline the try/catch here and leave a comment that this is for SVG in IE11.

gaearon · 2018-06-10T23:43:40Z

Would a fix like

if (typeof priorFocusedElem.focus === 'function') {
  priorFocusedElem.focus();
}

be sufficient then?

ThaddeusJiang · 2018-06-10T23:48:23Z

Yes, It's better.

gaearon · 2018-06-11T00:07:44Z

packages/react-dom/src/client/ReactInputSelection.js

      priorFocusedElem.focus();
-    } catch (e) {
+    } else {
      // The SVGElement don't have a focus method in IE11
      focusNode(priorFocusedElem);


Hmm, we don't need this part now, right?

gaearon · 2018-06-11T01:21:14Z

Have you verified this fixes the IE11 issue?

ThaddeusJiang · 2018-06-11T02:29:29Z

@gaearon Yes, this fixed the IE11 issue.

gaearon · 2018-06-11T02:39:34Z

Thanks!

193: Update dependency react to v16.4.1 r=magopian a=renovate[bot] This Pull Request updates dependency [react](https://github.com/facebook/react) from `v16.4.0` to `v16.4.1` <details> <summary>Release Notes</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@bvaughn] in [#12911](`https://github.com/facebook/react/pull/12911`)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@spirosikmd] in [#12135](`https://github.com/facebook/react/pull/12135`)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@ThaddeusJiang] in [#12996](`https://github.com/facebook/react/pull/12996`)) * Fix a range input not updating in some cases. ([@Illu] in [#12939](`https://github.com/facebook/react/pull/12939`)) * Fix input validation triggering unnecessarily in Firefox. ([@nhunzaker] in [#12925](`https://github.com/facebook/react/pull/12925`)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@nhunzaker] in [#12976](`https://github.com/facebook/react/pull/12976`)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@philipp-spiess] in [#12966](`https://github.com/facebook/react/pull/12966`)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@ericsoderberghp] in [#12985](`https://github.com/facebook/react/pull/12985`), [@gaearon] in [#13019](`https://github.com/facebook/react/pull/13019`)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@gaearon] in [#13017](`https://github.com/facebook/react/pull/13017`)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@fatfisz] in [#13030](`https://github.com/facebook/react/pull/13030`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>

25: Update react monorepo to v16.4.1 r=renovate[bot] a=renovate[bot] This Pull Request renovates the package group "react monorepo". - [react-dom](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` - [react](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` # Release Notes <details> <summary>facebook/react</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@bvaughn] in [#12911](`https://github.com/facebook/react/pull/12911`)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@spirosikmd] in [#12135](`https://github.com/facebook/react/pull/12135`)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@ThaddeusJiang] in [#12996](`https://github.com/facebook/react/pull/12996`)) * Fix a range input not updating in some cases. ([@Illu] in [#12939](`https://github.com/facebook/react/pull/12939`)) * Fix input validation triggering unnecessarily in Firefox. ([@nhunzaker] in [#12925](`https://github.com/facebook/react/pull/12925`)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@nhunzaker] in [#12976](`https://github.com/facebook/react/pull/12976`)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@philipp-spiess] in [#12966](`https://github.com/facebook/react/pull/12966`)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@ericsoderberghp] in [#12985](`https://github.com/facebook/react/pull/12985`), [@gaearon] in [#13019](`https://github.com/facebook/react/pull/13019`)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@gaearon] in [#13017](`https://github.com/facebook/react/pull/13017`)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@fatfisz] in [#13030](`https://github.com/facebook/react/pull/13030`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>

revert #11800

9871f37

because #12763

facebook-github-bot added the CLA Signed label Jun 8, 2018

gaearon requested changes Jun 8, 2018

View reviewed changes

use try/catch for SVG in IE11

f5abb78

use focusNode(element) when element.focus isn't a function.

18f6b9d

gaearon reviewed Jun 11, 2018

View reviewed changes

revert #11800

c6f8204

gaearon approved these changes Jun 11, 2018

View reviewed changes

gaearon changed the title ~~revert #11800~~ Fix an SVG focusing crash in IE11 Jun 11, 2018

gaearon merged commit c78957e into facebook:master Jun 11, 2018

gaearon mentioned this pull request Jun 11, 2018

priorFocusedElem.focus() throws in IE11 #12763

Closed

This was referenced Jul 3, 2018

Update react-dom in /packages/oc-template-react from 16.4.0 to 16.4.1 opencomponents/oc-template-react#245

Closed

Update react in /packages/oc-template-react from 16.4.0 to 16.4.1 opencomponents/oc-template-react#246

Closed

dependencies bot mentioned this pull request Jul 3, 2018

Update react in /packages/oc-template-react-compiler from 16.4.0 to 16.4.1 opencomponents/oc-template-react#248

Closed

dependencies bot mentioned this pull request Oct 1, 2018

Update react-dom in /modules/frontend from 16.3.0 to 16.5.2 project-accelerate/accelerate#277

Open

This was referenced Nov 1, 2018

Update react-dom in / from 16.2.0 to 16.6.0 leonardofaria/leozera-ui#253

Closed

Update react in / from 16.2.0 to 16.6.0 leonardofaria/leozera-ui#254

Closed

This was referenced Dec 1, 2018

Update react-test-renderer in /modules/frontend from 16.3.0 to 16.6.3 project-accelerate/accelerate#312

Open

Update react in /modules/frontend from 16.3.0 to 16.6.3 project-accelerate/accelerate#313

Open

This was referenced Mar 15, 2021

chore(deps): bump react-dom from 16.4.0 to 16.4.2 in /intro-react-v5 samuelsilvadev/front-end-master-courses#9

Merged

Bump react-dom from 16.4.0 to 16.4.2 in /client cdhenry/pivot#1

Open

This was referenced Sep 5, 2024

[Snyk] Fix for 104 vulnerabilities Omrisnyk/lock-walker#65

Open

[Snyk] Fix for 104 vulnerabilities Omrisnyk/lock-walker#66

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix an SVG focusing crash in IE11 #12996

Fix an SVG focusing crash in IE11 #12996

ThaddeusJiang commented Jun 8, 2018

facebook-github-bot commented Jun 8, 2018

facebook-github-bot commented Jun 8, 2018

gaearon Jun 8, 2018

gaearon commented Jun 10, 2018

ThaddeusJiang commented Jun 10, 2018

gaearon Jun 11, 2018

gaearon commented Jun 11, 2018

ThaddeusJiang commented Jun 11, 2018

gaearon commented Jun 11, 2018

Fix an SVG focusing crash in IE11 #12996

Fix an SVG focusing crash in IE11 #12996

Conversation

ThaddeusJiang commented Jun 8, 2018

facebook-github-bot commented Jun 8, 2018

facebook-github-bot commented Jun 8, 2018

gaearon Jun 8, 2018

Choose a reason for hiding this comment

gaearon commented Jun 10, 2018

ThaddeusJiang commented Jun 10, 2018

gaearon Jun 11, 2018

Choose a reason for hiding this comment

gaearon commented Jun 11, 2018

ThaddeusJiang commented Jun 11, 2018

gaearon commented Jun 11, 2018