Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

honor displayName set on ForwardRef if available #13615

Merged
merged 4 commits into from
Sep 11, 2018
Merged

honor displayName set on ForwardRef if available #13615

merged 4 commits into from
Sep 11, 2018

Commits on Sep 11, 2018

  1. add failing test

    @quantizor
    quantizor committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    26e0aa1 View commit details
    Browse the repository at this point in the history

  2. honor displayName set on ForwardRef if available 

    Since React.forwardRef returns a component object, some users
(including styled-components and react-native) are starting to
decorate them with various statics including displayName.

This adjusts React's various name-getters to honor this if set and
surface the name in warnings and hopefully DevTools.
    @quantizor
    quantizor committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    807aee5 View commit details
    Browse the repository at this point in the history

  3. fix typing

    @quantizor
    quantizor committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    7b1b7b7 View commit details
    Browse the repository at this point in the history

  4. Refine later

    @gaearon
    gaearon authored Sep 11, 2018
    Configuration menu
    Copy the full SHA
    fc03666 View commit details
    Browse the repository at this point in the history