-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression: Errors not emitted in streams #14314
Fix regression: Errors not emitted in streams #14314
Conversation
Regression introduced in facebook#14182 resulted in errors no longer being emitted on streams, breaking many consumers. Co-authored-by: Elliot Jalgard <elliot.j@live.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not deeply familiar with Node Readable API but base implementation is function (err, cb) { this.push(null); cb(err); }'
so this looks good.
Hi, when will this change be released? |
If you need it urgently you can build React from master and get the fix. I can't give you an exact day — we generally release things when we feel they're stable, and this means giving some time for other changes to shake out. Probably within a few weeks. |
Thanks for your response Dan, we’ll build from the commit.
Elliott
Elliott Greaves
…Sent from my mobile
On 6 Dec 2018, at 16:07, Dan Abramov ***@***.***> wrote:
If you need it urgently you can build React from master and get the fix. I can't give you an exact day — we generally release things when we feel they're stable, and this means giving some time for other changes to shake out. Probably within a few weeks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Fix appears to be in 16.7.0 |
Regression introduced in facebook#14182 resulted in errors no longer being emitted on streams, breaking many consumers. Co-authored-by: Elliot Jalgard <elliot.j@live.se>
Regression introduced in facebook#14182 resulted in errors no longer being emitted on streams, breaking many consumers. Co-authored-by: Elliot Jalgard <elliot.j@live.se>
Regression introduced in #14182 resulted in errors no longer being emitted on streams, breaking consumers.
The cause is a faulty implementation of the
destroy()
method ofReactMarkupReadableStream
, which resulted in noerror
event being thrown even though one expected it.This patch fixes that + adds tests for the fixes.