Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Object.is polyfill #14334

Merged
merged 9 commits into from
Jan 8, 2019
Merged

Separate Object.is polyfill #14334

merged 9 commits into from
Jan 8, 2019

Conversation

mmarkelov
Copy link
Contributor

There are some places where Object.is polyfill is used, so I suppose we can move it to separate file

@sizebot
Copy link

sizebot commented Nov 27, 2018 •
edited
Loading

ReactDOM: size: -0.0%, gzip: -0.1%

Details of bundled changes.

Comparing: a22880e...cd0e7c1

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.2% 723.78 KB 722.93 KB 167.25 KB 166.92 KB UMD_DEV
react-dom.production.min.js -0.0% -0.1% 97.8 KB 97.76 KB 31.84 KB 31.82 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.1% 100.78 KB 100.75 KB 32.55 KB 32.51 KB UMD_PROFILING
react-dom.development.js -0.1% -0.2% 718.83 KB 717.99 KB 165.85 KB 165.51 KB NODE_DEV
react-dom.production.min.js -0.0% -0.1% 97.79 KB 97.76 KB 31.38 KB 31.36 KB NODE_PROD
react-dom.profiling.min.js -0.0% -0.1% 100.88 KB 100.85 KB 31.99 KB 31.97 KB NODE_PROFILING
ReactDOM-dev.js -0.1% -0.2% 740.23 KB 739.37 KB 166.85 KB 166.53 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.2% 308.18 KB 307.81 KB 56.78 KB 56.69 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.2% 315.07 KB 314.7 KB 58.21 KB 58.1 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js -0.1% -0.2% 724.06 KB 723.22 KB 167.36 KB 167.03 KB UMD_DEV
react-dom-unstable-fire.production.min.js -0.0% -0.1% 97.81 KB 97.78 KB 31.85 KB 31.83 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js -0.0% -0.1% 100.8 KB 100.76 KB 32.55 KB 32.52 KB UMD_PROFILING
react-dom-unstable-fire.development.js -0.1% -0.2% 719.11 KB 718.27 KB 165.97 KB 165.63 KB NODE_DEV
react-dom-unstable-fire.production.min.js -0.0% -0.1% 97.8 KB 97.77 KB 31.39 KB 31.37 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js -0.0% -0.1% 100.89 KB 100.86 KB 32 KB 31.98 KB NODE_PROFILING
ReactFire-dev.js -0.1% -0.2% 739.38 KB 738.52 KB 166.79 KB 166.45 KB FB_WWW_DEV
ReactFire-prod.js -0.1% -0.2% 296.77 KB 296.4 KB 54.35 KB 54.27 KB FB_WWW_PROD
ReactFire-profiling.js -0.1% -0.2% 303.59 KB 303.22 KB 55.82 KB 55.72 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 44.59 KB 44.59 KB 12.24 KB 12.24 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 9.74 KB 9.74 KB 3.65 KB 3.64 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.61 KB 60.61 KB 15.92 KB 15.91 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 11.01 KB 11.01 KB 3.81 KB 3.81 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.29 KB 60.29 KB 15.79 KB 15.78 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.75 KB 10.75 KB 3.71 KB 3.71 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 123.89 KB 123.91 KB 33.09 KB 33.09 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 16.99 KB 16.99 KB 6.53 KB 6.52 KB UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 120.02 KB 120.04 KB 32.16 KB 32.17 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 16.9 KB 16.9 KB 6.52 KB 6.52 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 121.2 KB 121.22 KB 31.79 KB 31.81 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.1% -0.1% 44.42 KB 44.46 KB 10.3 KB 10.29 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% 0.0% 122.08 KB 122.1 KB 32.7 KB 32.71 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 17.77 KB 17.77 KB 6.83 KB 6.83 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.63 KB 3.63 KB 1.44 KB 1.44 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 706 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.45 KB 3.45 KB 1.39 KB 1.39 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 637 B 636 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.7 KB 3.7 KB 1.42 KB 1.42 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 667 B 666 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.2% -0.2% 504.18 KB 503.34 KB 111.12 KB 110.89 KB UMD_DEV
react-art.production.min.js -0.0% -0.2% 89.96 KB 89.93 KB 27.66 KB 27.61 KB UMD_PROD
react-art.development.js -0.2% -0.3% 435.67 KB 434.83 KB 94.02 KB 93.78 KB NODE_DEV
react-art.production.min.js -0.1% -0.3% 54.93 KB 54.9 KB 16.99 KB 16.94 KB NODE_PROD
ReactART-dev.js -0.2% -0.2% 443.9 KB 443.05 KB 92.97 KB 92.76 KB FB_WWW_DEV
ReactART-prod.js -0.2% -0.3% 183.62 KB 183.24 KB 31.39 KB 31.29 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.2% -0.2% 568.59 KB 567.74 KB 123.54 KB 123.33 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.2% -0.2% 238.83 KB 238.46 KB 42 KB 41.9 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.2% -0.3% 244.7 KB 244.33 KB 43.36 KB 43.25 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.2% -0.2% 568.29 KB 567.43 KB 123.46 KB 123.25 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.1% -0.1% 224.35 KB 224.17 KB 38.96 KB 38.92 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% -0.1% 230.09 KB 229.91 KB 40.3 KB 40.26 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.2% -0.2% 559.1 KB 558.24 KB 121.1 KB 120.9 KB RN_FB_DEV
ReactFabric-prod.js -0.2% -0.3% 233.34 KB 232.97 KB 40.77 KB 40.67 KB RN_FB_PROD
ReactFabric-profiling.js -0.2% -0.2% 238.3 KB 237.93 KB 42.12 KB 42.02 KB RN_FB_PROFILING
ReactFabric-dev.js -0.2% -0.2% 559.13 KB 558.28 KB 121.12 KB 120.91 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% -0.1% 218.53 KB 218.35 KB 37.71 KB 37.67 KB RN_OSS_PROD
ReactFabric-profiling.js -0.1% -0.1% 223.28 KB 223.11 KB 39.12 KB 39.07 KB RN_OSS_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.2% -0.2% 448.89 KB 448.05 KB 96.8 KB 96.56 KB UMD_DEV
react-test-renderer.production.min.js -0.1% -0.1% 56.26 KB 56.22 KB 17.26 KB 17.24 KB UMD_PROD
react-test-renderer.development.js -0.2% -0.2% 443.85 KB 443 KB 95.58 KB 95.35 KB NODE_DEV
react-test-renderer.production.min.js -0.1% -0.1% 55.92 KB 55.89 KB 17.11 KB 17.1 KB NODE_PROD
ReactTestRenderer-dev.js -0.2% -0.2% 452.27 KB 451.42 KB 94.87 KB 94.67 KB FB_WWW_DEV
react-test-renderer-shallow.development.js -0.8% -1.5% 25.88 KB 25.67 KB 7.06 KB 6.95 KB UMD_DEV
react-test-renderer-shallow.production.min.js -0.0% -0.1% 7.31 KB 7.31 KB 2.39 KB 2.38 KB UMD_PROD
react-test-renderer-shallow.development.js -1.0% -1.8% 20.18 KB 19.97 KB 5.61 KB 5.51 KB NODE_DEV
react-test-renderer-shallow.production.min.js -0.0% -0.1% 7.96 KB 7.96 KB 2.64 KB 2.64 KB NODE_PROD
ReactShallowRenderer-dev.js -1.1% -2.2% 18.13 KB 17.93 KB 4.75 KB 4.64 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.2% -0.3% 433.5 KB 432.66 KB 92.51 KB 92.27 KB NODE_DEV
react-reconciler.production.min.js -0.1% -0.1% 56.05 KB 56.02 KB 16.82 KB 16.8 KB NODE_PROD
react-reconciler-persistent.development.js -0.2% -0.3% 431.88 KB 431.04 KB 91.86 KB 91.63 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.1% -0.1% 56.06 KB 56.03 KB 16.83 KB 16.8 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% -0.0% 15.4 KB 15.4 KB 4.83 KB 4.83 KB NODE_DEV

Generated by 🚫 dangerJS

trueadm
trueadm approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for finding this! :)

@trueadm trueadm merged commit a9b035b into facebook:master Jan 8, 2019
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@mmarkelov @jetoneza
Separate Object.is polyfill (facebook#14334)
efd1d95 
* Separate_Object_Is_Polyfill
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@mmarkelov @n8schloss
Separate Object.is polyfill (facebook#14334)
bb3fb19 
* Separate_Object_Is_Polyfill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@kulek1 kulek1 kulek1 approved these changes

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmarkelov @sizebot @trueadm @kulek1 @hg-pyun @facebook-github-bot