Add support for Suspense & lazy() to the react-is package #14423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: ce43a8c...ba0c834 react-is
Generated by 🚫 dangerJS |
bvaughn
approved these changes
Dec 12, 2018
| @@ -152,6 +156,14 @@ describe('ReactIs', () => { | |||
| expect(ReactIs.isMemo(Component)).toBe(false); | |||
| }); | |||
|
|
|||
| it('should identify lazy', () => { | |||
| const Component = () => React.createElement('div'); | |||
| const lazyComponent = React.lazy(() => Component); | |||
There was a problem hiding this comment.
nit: This should actually be React.lazy(() => ({default: Component}); but that doesn't matter for the purposes of this test.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…4423) * Add support for lazy & Suspense to react-is
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…4423) * Add support for lazy & Suspense to react-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "react-is" package appears to lack checks for
React.Suspense&React.lazy(). Since libraries like enzyme depend on this to implement proper support for these element types I figured I'd take a stab at adding them.I ran into some
yarn testrelated issues on the way, as I seem to be unable to run the whole test suite (on Windows), only ayarn test --watch ReactIsdoes the trick. Should I file an issue for this?