Allow node 11 as devEngine #14450
Merged
Allow node 11 as devEngine #14450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using node 11 throws incompatibility error. This fixes it. Only test I performed was to run `yarn build -- --type=RN_OSS` everything seemed ok.
rajendraarora16
added a commit
to rajendraarora16/react
that referenced
this pull request
Dec 26, 2018
Allow node 11 as devEngine (facebook#14450)
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Using node 11 throws incompatibility error. This fixes it. Only test I performed was to run `yarn build -- --type=RN_OSS` everything seemed ok.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Using node 11 throws incompatibility error. This fixes it. Only test I performed was to run `yarn build -- --type=RN_OSS` everything seemed ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using node 11 throws incompatibility error. This fixes it. Only test I performed was to run
yarn build -- --type=RN_OSSeverything seemed ok.Usual
yarn testalso passes.