Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate SchedulerFeatureFlags instead of using ReactFeatureFlags #14455

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Create separate SchedulerFeatureFlags instead of using ReactFeatureFlags #14455

merged 1 commit into from
Dec 18, 2018

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Dec 18, 2018

No description provided.

@acdlite acdlite requested a review from sebmarkbage December 18, 2018 01:48
@acdlite
Copy link
Collaborator Author

acdlite commented Dec 18, 2018

Test plan: Run yarn build scheduler and inspect the build artifacts. www build should have enableSchedulerDebugging = true and npm build should have enableSchedulerDebugging = false.

@acdlite acdlite merged commit 653bc58 into facebook:master Dec 18, 2018
@sizebot
Copy link

sizebot commented Dec 18, 2018

Details of bundled changes.

Comparing: 8bfef0d...e5bb06a

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js -4.4% -7.3% 23.44 KB 22.42 KB 6.41 KB 5.94 KB NODE_DEV
Scheduler-dev.js -4.4% -6.0% 23.69 KB 22.65 KB 6.37 KB 5.99 KB FB_WWW_DEV
Scheduler-prod.js -0.2% -0.7% 13.43 KB 13.4 KB 2.88 KB 2.86 KB FB_WWW_PROD
scheduler-tracing.development.js 0.0% 0.0% 10.32 KB 10.32 KB 2.38 KB 2.38 KB NODE_DEV
scheduler-tracing.production.min.js 0.0% 🔺+0.3% 728 B 728 B 381 B 382 B NODE_PROD
scheduler-tracing.profiling.min.js 0.0% +0.1% 3.26 KB 3.26 KB 998 B 999 B NODE_PROFILING

Generated by 🚫 dangerJS

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@acdlite @jetoneza
Create separate SchedulerFeatureFlags instead of using ReactFeatureFl…
c4f8bd5 
…ags (facebook#14455)
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@acdlite @n8schloss
Create separate SchedulerFeatureFlags instead of using ReactFeatureFl…
ec61fcd 
…ags (facebook#14455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @sebmarkbage @facebook-github-bot