Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint-plugin-react-hooks/exhaustive-deps rule to check stale closure dependencies #14636

Merged
merged 33 commits into from
Feb 20, 2019
Merged

Add eslint-plugin-react-hooks/exhaustive-deps rule to check stale closure dependencies #14636

merged 33 commits into from
Feb 20, 2019

Commits on Feb 19, 2019

  1. Add ESLint rule for useEffect/useCallback/useMemo Hook dependencies

    @calebmer @gaearon
    calebmer authored and gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    c0eafd8 View commit details
    Browse the repository at this point in the history

  2. Fix ReactiveDependencies rule

    @jamiebuilds @gaearon
    jamiebuilds authored and gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    6e2ba67 View commit details
    Browse the repository at this point in the history

  3. fix lint errors

    @jamiebuilds @gaearon
    jamiebuilds authored and gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    4704a98 View commit details
    Browse the repository at this point in the history

  4. Support useLayoutEffect

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    6f67ef1 View commit details
    Browse the repository at this point in the history

  5. Add some failing tests and comments

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    da75f31 View commit details
    Browse the repository at this point in the history

  6. Gather dependencies in child scopes too

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    58183fe View commit details
    Browse the repository at this point in the history

  7. If we don't find foo.bar.baz in deps, try foo.bar, then foo

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    d1515f4 View commit details
    Browse the repository at this point in the history

  8. foo is enough for both foo.bar and foo.baz

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    57ebe56 View commit details
    Browse the repository at this point in the history

  9. Shorter rule name

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    369aa61 View commit details
    Browse the repository at this point in the history

  10. Add fixable meta

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    2df41d8 View commit details
    Browse the repository at this point in the history

  11. Remove a bunch of code and start from scratch

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    3b3d7da View commit details
    Browse the repository at this point in the history

  12. [WIP] Only report errors from dependency array 

    This results in nicer editing experience. Also has autofix.
    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    d4d501b View commit details
    Browse the repository at this point in the history

  13. Fix typo

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    695693c View commit details
    Browse the repository at this point in the history

  14. [Temp] Skip all tests

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    340bffb View commit details
    Browse the repository at this point in the history

  15. Fix the first test

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    3832eb3 View commit details
    Browse the repository at this point in the history

  16. Revamp the test suite

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    244a1ff View commit details
    Browse the repository at this point in the history

  17. Fix [foo] to include foo.bar

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    58e38ca View commit details
    Browse the repository at this point in the history

  18. Don't suggest call expressions

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    0aea58e View commit details
    Browse the repository at this point in the history

  19. Special case 'current' for refs

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    14b2229 View commit details
    Browse the repository at this point in the history

  20. Don't complain about known static deps

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    366d5df View commit details
    Browse the repository at this point in the history

  21. Support useImperativeHandle

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    3d46a1e View commit details
    Browse the repository at this point in the history

  22. Better punctuation and formatting

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    3679627 View commit details
    Browse the repository at this point in the history

  23. More uniform message format

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    5d2c991 View commit details
    Browse the repository at this point in the history

  24. Treat React.useRef/useState/useReducer as static too

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    e0203cb View commit details
    Browse the repository at this point in the history

  25. Add special message for ref.current

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    54c2e16 View commit details
    Browse the repository at this point in the history

  26. Add a TODO case

    @gaearon
    gaearon committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    6fd2d12 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Alphabetize the autofix

    @gaearon
    gaearon committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    0c722bb View commit details
    Browse the repository at this point in the history

  2. Only alphabetize if it already was

    @gaearon
    gaearon committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    12aeaca View commit details
    Browse the repository at this point in the history

  3. Don't add static deps by default

    @gaearon
    gaearon committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    c40bcaa View commit details
    Browse the repository at this point in the history

  4. Add an undefined variable case

    @gaearon
    gaearon committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    56785b5 View commit details
    Browse the repository at this point in the history

  5. Tweak wording

    @gaearon
    gaearon committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    294b474 View commit details
    Browse the repository at this point in the history

  6. Rename to exhaustive-deps

    @gaearon
    gaearon committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    2f86a69 View commit details
    Browse the repository at this point in the history

  7. Clean up / refactor a little bit

    @gaearon
    gaearon committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    8b554ca View commit details
    Browse the repository at this point in the history