Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 16.8.0 changelog and update some READMEs #14692

Closed
wants to merge 18 commits into from
Closed

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jan 24, 2019

NOTE BEFORE MERGE: set the release date.

@gaearon gaearon changed the title Add 16.8.0 changelog Add 16.8.0 changelog and update some READMEs Jan 24, 2019
@RobinMalfait
Copy link

IT'S HAPPENING, 4th of February!

@GonchuB
Copy link

GonchuB commented Jan 29, 2019

🎣

@sami616
Copy link

sami616 commented Jan 29, 2019

YESSS! 💥

Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include the breaking API changes, that we haven't made yet, into the change log too.

@gaearon
Copy link
Collaborator Author

gaearon commented Jan 29, 2019

I’ll add the useReducer one, is there more?

@Jessidhia
Copy link
Contributor

I'm curious about the fate of useCallback. It seemed to be the one most likely to change early on.

@gaearon
Copy link
Collaborator Author

gaearon commented Jan 29, 2019

No changes planned to it for now.

On a side note — we appreciate the community excitement but it’s creating some noise across issues and PRs that makes it more challenging to get the work done and make sure we don’t forget anything. We’d appreciate a bit patience and restraint in posting until we flesh the details out and push the release. I put a date as an estimate but we’ve already moved it a few times, and won’t hesitate to move it again if we don’t feel the release is solid enough. It will be ready when it’s ready. Thanks.

CHANGELOG.md Outdated Show resolved Hide resolved
@RedNinjaX
Copy link

So no kind of useErrorBoundary hook before release? Was looking forward to ridding of my last class component but this is none the less exciting news. Excellent job, I can't wait!

Co-Authored-By: gaearon <dan.abramov@gmail.com>
@gaearon
Copy link
Collaborator Author

gaearon commented Jan 29, 2019

No, it wouldn’t be a good candidate for a Hook. This is about different example but maybe it helps: https://overreacted.io/why-isnt-x-a-hook/

@cullophid
Copy link

https://youtu.be/ckbhnKVRWUA

@mohsinulhaq
Copy link

I am so proud of this community 😊

@andrescalco
Copy link

It's time!

@ppbl
Copy link

ppbl commented Feb 4, 2019

What time is it released?😄

@mohsinulhaq
Copy link

mohsinulhaq commented Feb 4, 2019

i don't think the requested changes were addressed :(

CHANGELOG.md Outdated
@@ -6,6 +6,33 @@
</summary>
</details>

## 16.8.0 (Maybe February 4, 2019 but we've moved it before so please don't rely on it.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete this maybe, it will surely release if you do 🥑

@jeemyeong
Copy link

I am still waiting for what I was looking forward to.

@ecklf
Copy link

ecklf commented Feb 5, 2019

I am still waiting for what I was looking forward to.

Good things come for those who wait 👍

@mohsinulhaq
Copy link

mohsinulhaq commented Feb 5, 2019

*insert waiting pablo escobar meme here*

CHANGELOG.md Outdated

* Support Hooks in the shallow renderer. ([@trueadm](https://github.com/trueadm) in [#14567](https://github.com/facebook/react/pull/14567))
* Fix wrong state in `shouldComponentUpdate` in the presence of `getDerivedStateFromProps` for Shallow Renderer. ([@chenesan](https://github.com/chenesan) in [#14613](https://github.com/facebook/react/pull/14613))
* Add `ReactTestUtils.act()` for batching updates so that tests more closely match real behavior. ([@threepointone](https://github.com/threepointone) in [#14744])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn’t work. Needs to be an actual link.

Also technically not test renderer but test utils. See past Changelogs.

Or I guess there should be two entries because there are two new APIs. One in test renderer section and one in test utils.

pull bot pushed a commit to SimenB/react that referenced this pull request Feb 6, 2019
* Add 16.8.0 changelog

* Mention ESLint plugin

* Remove experimental notices from the ESLint plugin README

* Update CHANGELOG.md

* Add more details for Hooks

* fix

* Set a date

* Update CHANGELOG.md

Co-Authored-By: gaearon <dan.abramov@gmail.com>

* Update CHANGELOG.md

* useReducer in changelog

* Add to changelog

* Update date

* Add facebook#14119 to changelog

* Add facebook#14744 to changelog

* Fix PR links

* act() method was added to test utils, too

* Updated release date to February 6th
pull bot pushed a commit to SimenB/react that referenced this pull request Feb 6, 2019
* Add 16.8.0 changelog

* Mention ESLint plugin

* Remove experimental notices from the ESLint plugin README

* Update CHANGELOG.md

* Add more details for Hooks

* fix

* Set a date

* Update CHANGELOG.md

Co-Authored-By: gaearon <dan.abramov@gmail.com>

* Update CHANGELOG.md

* useReducer in changelog

* Add to changelog

* Update date

* Add facebook#14119 to changelog

* Add facebook#14744 to changelog

* Fix PR links

* act() method was added to test utils, too

* Updated release date to February 6th
pull bot pushed a commit to chojar/react that referenced this pull request Feb 6, 2019
* Add 16.8.0 changelog

* Mention ESLint plugin

* Remove experimental notices from the ESLint plugin README

* Update CHANGELOG.md

* Add more details for Hooks

* fix

* Set a date

* Update CHANGELOG.md

Co-Authored-By: gaearon <dan.abramov@gmail.com>

* Update CHANGELOG.md

* useReducer in changelog

* Add to changelog

* Update date

* Add facebook#14119 to changelog

* Add facebook#14744 to changelog

* Fix PR links

* act() method was added to test utils, too

* Updated release date to February 6th
@bvaughn
Copy link
Contributor

bvaughn commented Feb 6, 2019

Not sure what's going on with this PR. The "Squash and merge" button does nothing (just times out) but the commit has already been merged– (I've verified the contents of master against this PR)– so I'm going to just close it.

@bvaughn bvaughn closed this Feb 6, 2019
@bvaughn bvaughn deleted the gaearon-patch-3 branch February 6, 2019 09:08
@RobinMalfait
Copy link

@bvaughn is it because this is synced with some internal system?

@bvaughn
Copy link
Contributor

bvaughn commented Feb 6, 2019

No. We do development GitHub first. (We do sync from GitHub to our internal Mercurial repo, but not the other way around.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.