Revert #14756 changes to ReactFiberScheduler #14992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduced some bugs in concurrent mode during internal testing. Until we figure out a proper solution, I'm going to try reverting it. Not totally certain this is sufficient to unbreak the bugs we found, but I'm using this branch to determine that.
gaearon
reviewed
Mar 1, 2019
| @@ -172,19 +171,6 @@ export type Thenable = { | |||
| then(resolve: () => mixed, reject?: () => mixed): mixed, | |||
| }; | |||
|
|
|||
| // Intentionally not named imports because Rollup would | |||
There was a problem hiding this comment.
They're not being used in this module anymore. Do you mean comment these lines out?
There was a problem hiding this comment.
I'll comment them out so we don't forget next time we import Scheduler in this module
|
ReactDOM: size: -0.5%, gzip: 🔺+0.3% Details of bundled changes.Comparing: 59ef284...fbc9284 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
|
Ok after testing in a sandbox, I believe this fixes/unbreaks at least one of the bugs we found internally. |
bvaughn
approved these changes
Mar 1, 2019
With a note not to use named imports next time we import Scheduler in this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14756 PR introduced some bugs in concurrent mode during internal testing. I believe it's specifically related to the changes to ReactFiberScheduler. Until we figure out a proper solution, I'm going to try reverting it.
Not totally certain this is sufficient to unbreak the bugs we found, but I'm using this branch to determine that.