-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure for passive/non-passive event support for future API exploration #15036
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
858608b
Add infrastructure for passive/non-passive event support for future e…
trueadm 0ae3ba3
More Flow fixes
trueadm 3bd6176
Add fallback to Map if there is no WeakMap
trueadm 06f2c3b
Fix prettier
trueadm bbae02d
Update comment
trueadm 68934d8
Add isLegacy flag to EventPlugins
trueadm 37224ea
Handle fallback for no passive support
trueadm c683859
Fixed typo + improve code size
trueadm e7e742f
Changed to enum for passive event types and addressed PR feedback
trueadm ccf3884
Added comment to describe intent
trueadm c9fc178
use canUseDOM
trueadm 5d5b972
Cleaned up some logic and reduces more bytes
trueadm e186b09
Fix typo
trueadm 1dff1fc
Address nits
trueadm 8f79ee8
Addressed feedback and took a different approach with flags
trueadm 159280c
Merge branch 'master' into passive-event-listening
trueadm 2acacf8
Wrap function in flags
trueadm 3b67255
Remove more code that is not needed anymore
trueadm 5b044cf
Adds flag to another location
trueadm 8b34efa
Address feedback on addEventListener
trueadm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow | ||
*/ | ||
|
||
export type EventSystemFlags = number; | ||
|
||
export const PLUGIN_EVENT_SYSTEM = 1; | ||
export const RESPONDER_EVENT_SYSTEM = 1 << 1; | ||
export const IS_PASSIVE = 1 << 2; | ||
export const IS_ACTIVE = 1 << 3; | ||
export const PASSIVE_NOT_SUPPORTED = 1 << 4; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we don't use literal number(and add comment) here just like
maxSigned31BitInt
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are used to do bitwise operations on, as there can be a combination of the above being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the question was why
1 << 4
is used over16
.1 << 4
makes the intent clearer.maxSigned31BitInt
"solves" this by adding a comment. I don't think it matters what pattern is used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, just like @eps1lon said
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern is clear, as we may add more in the future, which is simply
1 << 5
,1 << 6
etc. We use this approach throughout the React codebase and we've verified that Google Closure Compiler simplifies the constant value.