Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React v16.8.5 #15192

Closed
wants to merge 12 commits into from
Closed

React v16.8.5 #15192

wants to merge 12 commits into from

Commits on Mar 22, 2019

  1. Improve async useEffect warning (facebook#15104)

    @gaearon
    gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    13a3788 View commit details
    Browse the repository at this point in the history

  2. Don't set the first option as selected in select tag with size attr… 

    …ibute (facebook#14242)

* Set 'size' attribute to select tag if it occurs before appending options

* Add comment about why size is assigned on select create. Tests

I added some more clarification for why size must be set on select
element creation:

- In the source code
- In the DOM test fixture
- In a unit test

* Use let, not const in select tag stub assignment
    @kulek1 @gaearon
    kulek1 authored and gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    d822d4b View commit details
    Browse the repository at this point in the history

  3. Fix shallow renderer not allowing hooks in forwardRef render functions ( 

    facebook#15100)

* test: Add test for shallow + forwardRef + hook

* fix(react-test-renderer): shallow forwardRef hooks
    @eps1lon @gaearon
    eps1lon authored and gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    8f73358 View commit details
    Browse the repository at this point in the history

  4. Use same example code for async effect warning (facebook#15118)

    @gaearon
    gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    6b86a6e View commit details
    Browse the repository at this point in the history

  5. Support React.memo in ReactShallowRenderer (facebook#14816) 

    * Support React.memo in ReactShallowRenderer

ReactShallowRenderer uses element.type frequently, but with React.memo
elements the actual type is element.type.type. This updates
ReactShallowRenderer so it uses the correct element type for Memo
components and also validates the inner props for the wrapped
components.

* Allow Rect.memo to prevent re-renders

* Support memo(forwardRef())

* Dont call memo comparison function on initial render

* Fix test

* Small tweaks
    @aweary @gaearon
    aweary authored and gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    62f5d4a View commit details
    Browse the repository at this point in the history

  6. [Shallow] Implement setState for Hooks and remount on type change (fa… 

    …cebook#15120)

* Throw away old shallow renderer state on type change

This worked in function components but was broken for classes. It incorrectly retained the old instance even if the type was different.

* Remove _previousComponentIdentity

We only needed this because we didn't correctly reset based on type. Now we do so this can go away.

* Use _reset when unmounting

* Use arbitrary componentIdentity

There was no particular reason it was set to element.type. We just wanted to check if something is a render phase update.

* Support Hook state updates in shallow renderer
    @gaearon
    gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    342fa78 View commit details
    Browse the repository at this point in the history

  7. Link to useLayoutEffect gist in a warning (facebook#15158)

    @gaearon
    gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    b5cb9d3 View commit details
    Browse the repository at this point in the history

  8. Add 16.8.5 changelog

    @gaearon
    gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    1fc13e4 View commit details
    Browse the repository at this point in the history

  9. Update CHANGELOG.md

    @gaearon
    gaearon authored Mar 22, 2019
    Configuration menu
    Copy the full SHA
    a0a2e84 View commit details
    Browse the repository at this point in the history

  10. Add more info to invalid hook call error message (facebook#15139) 

    * Add more info to invalid hook call error message

* Update other renderers + change call to action

* Update related tests for new hooks error message

* Fix lint errors
    @jaredpalmer @gaearon
    jaredpalmer authored and gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    fb572af View commit details
    Browse the repository at this point in the history

  11. Changelog

    @gaearon
    gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    f9e41e3 View commit details
    Browse the repository at this point in the history

  12. Release 16.8.5

    @gaearon
    gaearon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    84cc8a3 View commit details
    Browse the repository at this point in the history