Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for async event dispatching #15300

Merged

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 3, 2019

Adds a test for the async event batching PR that fixes the event queue conflict. Verified that a variant of this test fails when the withAsyncDispatching function is excluded (i.e., reproduces the issue with the existing API).

This patch should pass CI once @trueadm's PR is merged.

Ref #15257

Verified that a variant of this test fails as follows when the
`context.withAsyncDispatching` function is excluded (i.e., reproduces the
issue).

    Expected value to equal:
      ["press", "longpress", "longpresschange"]
    Received:
      ["press", "longpress", "longpress", "longpresschange"]
@necolas necolas force-pushed the react-events/async-dispatching-tests branch from df1e315 to 4abb87d Compare April 3, 2019 00:58
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trueadm trueadm merged commit fc6a9f1 into facebook:master Apr 3, 2019
@necolas necolas deleted the react-events/async-dispatching-tests branch April 3, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants