Add full TouchHitTarget hit slop (experimental event API) to ReactDOM #15308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds hydration support
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 49595e9...e5fe082 react-dom
react-art
react-native-renderer
react-test-renderer
react-noop-renderer
react-reconciler
Generated by 🚫 dangerJS |
|
The bundle size is interesting, although the non-min size goes up from 105.45 KB -> 105.52 KB, gzip actually goes down from 33.59 KB -> 33.56 KB. This doesn't seem like something I can get down, as I made a bunch of changes to places that can't DCE (switch cases that now contain |
|
so good |
sebmarkbage
reviewed
Apr 3, 2019
necolas
reviewed
Apr 4, 2019
packages/react-events/src/__tests__/TouchHitTarget-test.internal.js
Outdated
Show resolved
Hide resolved
necolas
reviewed
Apr 4, 2019
| let rightString = right ? `-${right}px;` : ''; | ||
| let bottomString = bottom ? `-${bottom}px;` : ''; | ||
|
|
||
| return `<div style="position:absolute;${topString}${leftString}${rightString}${bottomString}"></div>`; |
There was a problem hiding this comment.
It's worth noting that this could result in an undesirable experience for mouse-based interactions if the client-side JS fix is unavailable.
There was a problem hiding this comment.
Not sure how we tackle that one. Maybe @sebmarkbage had some ideas. I think you can maybe get away using some clever pointer media queries in a stylesheet.
|
Build is failing because of some strange |
sebmarkbage
approved these changes
Apr 5, 2019
| if (childFiber === null) { | ||
| return false; | ||
| } | ||
| const parentFiber = childFiber.return; |
There was a problem hiding this comment.
Normally we avoid traversing Fibers outside the reconciler but we already cheat this rule in the existing event system - for the same reasons as here. So this is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a complete replacement for the work suggested and originally started in #15261.
This PR aims add doing the following:
<TouchHitTarget>elements. These elements can have optional numerical and nullabletop,left,rightandbottomprops.getEventTargetChildElementandcommitEventTarget.Furthermore, I found that we can't actually test the hit slop logic in JSDOM because it doesn't support a bunch of the DOM APIs that
<TouchHitTarget>and respective event responders use. We'll need to come up with a different strategy for that, maybe @necolas has some ideas.Ref #15257