Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: disablePictureInPicture attribute for HTML5 videos #15334

Merged
merged 4 commits into from
Apr 25, 2019
Merged

ADD: disablePictureInPicture attribute for HTML5 videos #15334

merged 4 commits into from
Apr 25, 2019

Conversation

eek
Copy link
Contributor

@eek eek commented Apr 5, 2019

Fixes #15333

ahtee
ahtee reviewed Apr 5, 2019
View reviewed changes
Copy link

@ahtee ahtee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this PR work with the video player in the issue? #15333

@behzad888 behzad888 mentioned this pull request Apr 5, 2019
Closed
@eek
Copy link
Contributor Author

eek commented Apr 6, 2019

Added a few changes @ahtee, it works properly.

I haven't added anything to AttributeTableSnapshot because I got undefined on all values, didn't know how to actually fix it.

image

One last thing I wasn't sure about was if I needed to add the read property in attributes.js: read: getProperty('disablepictureinpicture')

autoPlay has it
but
muted doesn't have it

@eek eek mentioned this pull request Apr 8, 2019
Closed
cpojer
cpojer approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is supported in Chrome already and Safari soon, I think this should also be in React.

@cpojer cpojer merged commit f85aade into facebook:master Apr 25, 2019
@gaearon gaearon mentioned this pull request Jul 30, 2019
Merged
This was referenced Aug 17, 2019
Open
Open
Open
Open
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 24, 2019
Open
Merged
Merged
Closed
Merged
This was referenced Mar 10, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Open
Closed
Open
Merged
Merged
Open
Closed
Merged
Open
Open
This was referenced Mar 18, 2020
Open
Open
@tomprats tomprats mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahtee ahtee ahtee left review comments

@cpojer cpojer cpojer approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HTML5 Video Attribute disablePictureInPicture
4 participants
@eek @cpojer @ahtee @facebook-github-bot