Move EventTypes to ReactTypes #15364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicwhite
approved these changes
Apr 10, 2019
|
|
||
| export type ReactResponderEvent = { | ||
| nativeEvent: AnyNativeEvent, | ||
| target: Element | Document, |
There was a problem hiding this comment.
Are these global flow types? Will flow pass with these in fbsource/React Native?
There was a problem hiding this comment.
These are globals for Flow. We can revise them when we come to the RN work to add support for these events, but this should pass CI now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves in the Flow type annotations from
events/EventTypestoshared/ReactTypesto enable the RN build to properly consume these types without dependency misalignment.