Apply the Just Noticeable Difference to suspense timeouts #15367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
changed the title
|
The problem with this PR is that since we currently estimate the event time of "hi pri" updates as 5 seconds back in time. We think that we've waited a long time so if the hi-pri update suspends we'll wait a long time. Ideally we'd estimate these times correctly, but another approach is that we cap the timeout at the expiration time like we used it. |
|
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.3% Details of bundled changes.Comparing: 3e2e930...f46559a react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
acdlite
approved these changes
Apr 10, 2019
| // Computes the next Just Noticeable Difference (JND) boundary. | ||
| // The theory is that a person can't tell the difference between small differences in time. | ||
| // Therefore, if we wait a bit longer than necessary that won't translate to a noticeable | ||
| // difference in the experience. However, waiting for longer might mean that we can avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the suspended time based on how long we've already waited.
The theory is that a person can't tell the difference between small differences in time. Therefore, if we wait a bit longer than necessary that won't translate to a noticeable negative difference in the experience. However, waiting for longer might mean that we can avoid showing an intermediate loading state which is a positive difference. The longer we have already waited, the harder it is to tell small differences in time. Therefore, the longer we've already waited, the longer we can wait additionally. At some point we have to give up though. We pick a train model where the next boundary commits at a consistent schedule.