Experimental Event API: adds stopPropagation by default to Press
#15384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: -0.0%, gzip: -0.0% Details of bundled changes.Comparing: a9eff32...965ec07 react-dom
react-events
Generated by 🚫 dangerJS |
necolas
reviewed
Apr 11, 2019
| @@ -477,6 +539,38 @@ describe('Event responder: Press', () => { | |||
| expect(onLongPress).not.toBeCalled(); | |||
| }); | |||
|
|
|||
| it('is called but does not bubble', () => { | |||
There was a problem hiding this comment.
Let's perform all the bubbling tests in the "nested responders" block
There was a problem hiding this comment.
I was going to remove the nested responders block, as I thought it would be best to be about type of event. :/ I don't mind though.
There was a problem hiding this comment.
Sure. But it seems we could test the bubbling/not-bubbling for all events in a single test.
There was a problem hiding this comment.
I'll do this in a follow up tomorrow, will need some re-organizing of the test file. I also want to add some more test coverage for Press too :)
I want to get this in for now, so at least we have proper propagation stopping support.
necolas
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the default behaviour of stopping propagation on Press events, with the ability to override that feature using the
stopPropagationprop. I also had to refactor the event propagation system to account for async event contexts, which means aligningcontext.setTimeoutwithcontext.clearTimeoutso we can share actual timeouts where they have matching delays within the same context.