Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing SVG attributes #1557

Closed
wants to merge 1 commit into from
Closed

Added missing SVG attributes #1557

wants to merge 1 commit into from

Conversation

jonase
Copy link
Contributor

@jonase jonase commented May 18, 2014

Added fill-opacity, font-family, font-size, opacity, stroke-opacity attributes. Fixes #1171.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented May 20, 2014

Do all of these style attributes really add a lot? I ask this because we moved away from these things in HTML years ago and stuck them in style. font-family is pretty crazy being an element, an attribute, and on style. I don't work with SVG so I'm in the dark here.

@jonase
Copy link
Contributor Author

jonase commented May 20, 2014

Which attributes should be present? For example fill and stroke are currently supported by React but not fill-opacity and stroke-opacity. I think the easiest way to decide is to simply follow the SVG spec. Any other approach seems arbitrary.

@pedroteixeira
Copy link

Hi, I see lots of PR and issues about SVG. Is there any expected version date for having these missing SVG tags/attributes support in React?

@syranide
Copy link
Contributor

@pedroteixeira #1657

gradientTransform: 'gradientTransform',
gradientUnits: 'gradientUnits',
opacity: 'opacity',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need this one since the case & spelling is identical.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I removed this line when I merged it in.

@zpao zpao closed this in 0377ec5 Jun 20, 2014
@zpao
Copy link
Member

zpao commented Jun 20, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React does not support the svg 'opacity' attributes
5 participants