Create ReactFabric.stopSurface and use that for bridgeless mode binding #16164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejanzer
commented
Jul 19, 2019
| @@ -23,6 +23,10 @@ if (__DEV__) { | |||
| ReactFabric = require('../implementations/ReactFabric-prod'); | |||
| } | |||
|
|
|||
| BatchedBridge.registerCallableModule('ReactFabric', ReactFabric); | |||
| if (global.RN$Bridgeless) { | |||
There was a problem hiding this comment.
I'm assuming that this file gets synced over, too?
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
bvaughn
approved these changes
Jul 19, 2019
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
|
Whoops sorry for forgetting to actually merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Fabric we want to rename
unmountComponentAtNodetostopSurfaceto be consistent withstartSurface. BecauseunmountComponentAtNodeis called from native code (see ReactInstanceManager), we can't just delete it yet. Once this change syncs, I'll clean up usage ofunmountComponentAtNodein native code, then I'll come back and remove it completely.For more context, see facebook/react-native@3050581 (and additional discussion on D16273720 for fb employees). This PR also updates the binding I create in that diff for bridgeless mode to refer only to stopSurface.