Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flag that reverts #15650 #16372

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Aug 12, 2019

The change in #15650 has fully rolled out, so we can remove the flag
that reverts it.

The change in facebook#15650 has fully rolled out, so we can remove the flag
that reverts it.
@acdlite acdlite merged commit 3eeb645 into facebook:master Aug 12, 2019
@sizebot
Copy link

sizebot commented Aug 12, 2019

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 2716d91...fe4c57d

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% -0.1% 645.75 KB 645.08 KB 141.08 KB 140.94 KB UMD_DEV
react-art.production.min.js -0.1% -0.2% 101.77 KB 101.67 KB 31.12 KB 31.06 KB UMD_PROD
react-art.development.js -0.1% -0.1% 576.63 KB 575.96 KB 123.67 KB 123.54 KB NODE_DEV
react-art.production.min.js -0.2% -0.4% 66.78 KB 66.68 KB 20.39 KB 20.31 KB NODE_PROD
ReactART-dev.js -0.1% -0.1% 591.62 KB 590.97 KB 123.29 KB 123.17 KB FB_WWW_DEV
ReactART-prod.js -0.7% -0.9% 220.59 KB 218.98 KB 37.58 KB 37.26 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js -0.5% -0.5% 270.55 KB 269.32 KB 46.37 KB 46.13 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.4% -0.4% 278.94 KB 277.86 KB 47.87 KB 47.66 KB RN_OSS_PROFILING
ReactFabric-prod.js -0.5% -0.5% 262.74 KB 261.53 KB 45.11 KB 44.87 KB RN_OSS_PROD
ReactFabric-profiling.js -0.4% -0.4% 271.37 KB 270.29 KB 46.55 KB 46.35 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.1% -0.1% 733.99 KB 733.33 KB 155.18 KB 155.06 KB RN_FB_DEV
ReactFabric-prod.js -0.5% -0.5% 262.74 KB 261.54 KB 45.12 KB 44.88 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.1% -0.1% 724.36 KB 723.69 KB 153.46 KB 153.34 KB RN_OSS_DEV
ReactFabric-profiling.js -0.4% -0.4% 271.37 KB 270.29 KB 46.56 KB 46.36 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.1% -0.1% 724.52 KB 723.86 KB 153.54 KB 153.42 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.5% -0.5% 270.55 KB 269.31 KB 46.38 KB 46.14 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.4% -0.4% 278.93 KB 277.85 KB 47.87 KB 47.67 KB RN_FB_PROFILING
ReactFabric-dev.js -0.1% -0.1% 733.83 KB 733.16 KB 155.1 KB 154.98 KB RN_OSS_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.1% -0.2% 114.76 KB 114.66 KB 36.26 KB 36.2 KB NODE_PROFILING
react-dom-server.browser.development.js -0.0% -0.1% 137.78 KB 137.73 KB 36.32 KB 36.29 KB UMD_DEV
ReactDOM-dev.js -0.1% -0.1% 931.88 KB 931.18 KB 206.05 KB 205.94 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.26 KB 19.26 KB 7.22 KB 7.22 KB UMD_PROD
react-dom-test-utils.development.js -0.1% -0.2% 57.14 KB 57.09 KB 15.71 KB 15.68 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 701 B 700 B UMD_PROD
react-dom-test-utils.development.js -0.1% -0.1% 55.41 KB 55.36 KB 15.38 KB 15.36 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.98 KB 10.98 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.04 KB 1.04 KB 633 B 631 B NODE_PROD
react-dom.development.js -0.1% -0.1% 907.78 KB 907.07 KB 206.09 KB 205.95 KB UMD_DEV
react-dom.production.min.js -0.1% -0.2% 111.16 KB 111.06 KB 35.85 KB 35.79 KB UMD_PROD
ReactTestUtils-dev.js -0.1% -0.1% 52.76 KB 52.69 KB 14.1 KB 14.09 KB FB_WWW_DEV
react-dom.profiling.min.js -0.1% -0.1% 114.56 KB 114.46 KB 36.86 KB 36.81 KB UMD_PROFILING
react-dom.development.js -0.1% -0.1% 902.08 KB 901.37 KB 204.5 KB 204.36 KB NODE_DEV
react-dom-server.node.development.js -0.0% -0.1% 134.93 KB 134.88 KB 35.6 KB 35.58 KB NODE_DEV
react-dom.production.min.js -0.1% -0.2% 111.12 KB 111.02 KB 35.3 KB 35.23 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 19.6 KB 19.6 KB 7.37 KB 7.37 KB NODE_PROD
ReactDOM-prod.js -0.4% -0.5% 372.9 KB 371.3 KB 68.41 KB 68.07 KB FB_WWW_PROD
ReactDOM-profiling.js -0.4% -0.5% 377.43 KB 375.98 KB 69.39 KB 69.06 KB FB_WWW_PROFILING
react-dom-server.browser.development.js -0.0% -0.1% 133.91 KB 133.87 KB 35.38 KB 35.36 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.75 KB 10.75 KB 3.68 KB 3.67 KB UMD_PROD
ReactDOMServer-dev.js -0.0% -0.1% 137.93 KB 137.86 KB 34.91 KB 34.89 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 46.58 KB 46.58 KB 10.78 KB 10.78 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.39 KB 60.39 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.49 KB 10.49 KB 3.58 KB 3.58 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 667 B 666 B NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js -0.1% -0.1% 602.73 KB 601.99 KB 125.75 KB 125.61 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.01 KB 39.01 KB 9.91 KB 9.91 KB UMD_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 33.18 KB 33.18 KB 8.5 KB 8.5 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 11.56 KB 11.56 KB 3.63 KB 3.63 KB NODE_PROD
react-test-renderer.development.js -0.1% -0.1% 589.78 KB 589.17 KB 126.37 KB 126.27 KB UMD_DEV
react-test-renderer.production.min.js -0.1% -0.4% 68.7 KB 68.6 KB 21.18 KB 21.1 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 585.33 KB 584.71 KB 125.26 KB 125.17 KB NODE_DEV
react-test-renderer.production.min.js -0.1% -0.3% 68.41 KB 68.31 KB 20.89 KB 20.82 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.1% -0.1% 575.32 KB 574.61 KB 122.41 KB 122.27 KB NODE_DEV
react-reconciler.production.min.js -0.1% -0.4% 68.47 KB 68.37 KB 20.38 KB 20.29 KB NODE_PROD
react-reconciler-reflection.development.js -0.2% -0.4% 19.13 KB 19.08 KB 6.26 KB 6.23 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.58 KB 2.58 KB 1.13 KB 1.13 KB NODE_PROD
react-reconciler-persistent.development.js -0.1% -0.1% 572.41 KB 571.75 KB 121.15 KB 121.04 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.1% -0.4% 68.48 KB 68.38 KB 20.38 KB 20.3 KB NODE_PROD

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants