Make component stack last argument for deprecation warnings #16384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Aug 13, 2019
bvaughn
approved these changes
Aug 13, 2019
|
We should probably just migrate the rest to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component stack is the last argument when we use
warning().There are a few cases where we append stack manually. (Maybe some of them don't need to.) Those were originally written to be more readable. However, increasingly we're using tooling that treats last argument specially if it looks like a component stack. Both in RN and in FB5. We'll likely do the same in CRA/Next/etc.
So let's always put component stack last consistently. This makes it easier to build richer UIs and looks decent in console anyway.