Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename legacy "events" package to "legacy-events" #16388

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 14, 2019

This package conflicts with the built-in events Node package. We already had to add special casing for it, and I was having to add more in #16381 (since DevTools depends on events) so let's just rename it?

@sizebot
Copy link

sizebot commented Aug 14, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@bvaughn bvaughn merged commit b1a03df into facebook:master Aug 14, 2019
@bvaughn bvaughn deleted the rename-events branch August 14, 2019 14:33
@ashtonsix
Copy link

hey @bvaughn, does "legacy" in the package name indicate React will change how synthetic events work soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants