Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better error reporting for print-warnings errors #16394

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 14, 2019

When parsing fails, at least show which file the parsing error pertains to. The line/col numbers aren't useful by themselves.

Before

Screen Shot 2019-08-14 at 1 51 15 PM

After

Screen Shot 2019-08-14 at 1 51 22 PM

@sizebot
Copy link

sizebot commented Aug 14, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@bvaughn bvaughn merged commit 868d02d into facebook:master Aug 14, 2019
@bvaughn bvaughn deleted the print-warnings-catch branch August 14, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants