Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)"" #16525

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)"" #16525

merged 2 commits into from
Aug 21, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 21, 2019

Reverts #16522

It was a misunderstanding — the PR was fine. So we can include it.

@gaearon gaearon requested a review from threepointone August 21, 2019 14:41
@gaearon gaearon merged commit c433fbb into master Aug 21, 2019
@sizebot
Copy link

sizebot commented Aug 21, 2019 •
edited
Loading

Details of bundled changes.

Comparing: 507f0fb...d519314

eslint-plugin-react-hooks

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
eslint-plugin-react-hooks.development.js +0.3% -0.1% 75.01 KB 75.25 KB 17.32 KB 17.31 KB NODE_DEV
eslint-plugin-react-hooks.production.min.js 🔺+1.0% -0.2% 19.95 KB 20.14 KB 6.91 KB 6.9 KB NODE_PROD
ESLintPluginReactHooks-dev.js +0.4% 0.0% 80.5 KB 80.82 KB 17.83 KB 17.83 KB FB_WWW_DEV

Generated by 🚫 dangerJS

@kassens kassens deleted the revert-16522-revert-top-level-use-calls branch November 29, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @threepointone @facebook-github-bot