Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only warn in case the fourth argument is a function #16543

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Only warn in case the fourth argument is a function #16543

merged 1 commit into from
Aug 22, 2019

Conversation

brunoscopelliti
Copy link

Ref. #16526.

As per @gaearon 's suggestion, this PR scope down the warning to just the case when second argument is a function.

@sizebot
Copy link

sizebot commented Aug 22, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@gaearon gaearon merged commit 16c3408 into facebook:master Aug 22, 2019
@gaearon
Copy link
Collaborator

gaearon commented Aug 22, 2019

Thanks.

@brunoscopelliti brunoscopelliti deleted the issue-16526 branch August 26, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brunoscopelliti @sizebot @gaearon @facebook-github-bot