[react-events] Adds preventKeys support to Keyboard responder #16642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 92f094d...56cb454 react-events
|
necolas
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
There are situations where it might be necessary to preventDefault only if a modifier key is also held. We should check with Microsoft if there were specific use cases we can reference. Not sure what a nice way to support that could be, maybe:
useKeyboard({
preventKeys: [
'Space',
// second element as "conditions" associated with the native event
[ 'Enter', { metaKey: true } ]
// or custom string combos if there is a limited subset of keys that this applies to
'Enter+Meta'
]
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to natively
preventDefaulton the Keyboard responder. This is done via apreventKeysprop, which takes an array of key strings that should be preventing during thekeydownevent; along with adefaultPreventedflag on the callback's event object.