[react-events] Various core tweaks for event responder system #16654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: af03276...28b73a6 react-art
react-dom
react-test-renderer
react-reconciler
react-native-renderer
|
trueadm
commented
Sep 4, 2019
| while (node !== null) { | ||
| if (node === parentFiber || node === parentAlternateFiber) { | ||
| return true; | ||
| if (childFiber != null && parentFiber != null) { |
There was a problem hiding this comment.
This was the fix taken from the other PR.
necolas
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few fixes and core changes that are required for having event listeners/responders on scope components:
Removes
responderTargetfrom the responder event object. Insteadcontext.getCurrentTarget()has been introduced that achieves the same purpose, without needing to mutate the event object. Furthermore, this works with scopes, which do not have a direct DOM node (instead the nearest current DOM from the target is picked up).Fixes a bug @necolas found and fixed in another PR, which also came up in this with the responder target changes above, so they were needed here too.
Scope components via
React.unstable_createScopenow accept event responders via thelistenersprop, like host components can. This makes it easier to compose scopes that need to tight control over handling things like keyboard/focus interactions.