Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-a11y] Add react-ui/accessibility to bundle build #16804

Merged
merged 4 commits into from
Sep 17, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 17, 2019

In order to test the experimental accessibility components internally at FB, we need to be able to build the latest components so they get included in our syncs. This includes an accessibility bundle so we can test this out internally. Also, I made sure that our mappings for FB externals gets re-written appropriately, as our internal system won't recognise a react-ui package.

@sizebot
Copy link

sizebot commented Sep 17, 2019

Details of bundled changes.

Comparing: f40ceb0...b7b3efe

react-ui

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-ui-events/focus.development.js 0.0% 0.0% 10.92 KB 10.92 KB 2.36 KB 2.36 KB UMD_DEV
react-ui-events/press.development.js 0.0% +0.1% 4.37 KB 4.37 KB 1.3 KB 1.3 KB UMD_DEV
react-ui-events/tap.development.js 0.0% +0.1% 16.39 KB 16.39 KB 3.66 KB 3.66 KB UMD_DEV
react-ui-events/focus.production.min.js 0.0% 🔺+0.1% 4.09 KB 4.09 KB 1.39 KB 1.39 KB UMD_PROD
react-ui-events/press.production.min.js 0.0% 🔺+0.3% 2.02 KB 2.02 KB 929 B 932 B UMD_PROD
react-ui-events/tap.production.min.js 0.0% 🔺+0.1% 5.8 KB 5.8 KB 2.24 KB 2.24 KB UMD_PROD
ReactFocusTable-dev.js n/a n/a 0 B 6.69 KB 0 B 1.58 KB FB_WWW_DEV
react-ui-events/context-menu.development.js 0.0% +0.3% 2.67 KB 2.67 KB 999 B 1002 B UMD_DEV
react-ui-events/input.development.js 0.0% +0.1% 4.51 KB 4.51 KB 1.44 KB 1.44 KB UMD_DEV
react-ui-events/scroll.development.js 0.0% +0.1% 6.29 KB 6.29 KB 1.65 KB 1.65 KB UMD_DEV
react-ui-events/context-menu.production.min.js 0.0% 🔺+0.1% 1.38 KB 1.38 KB 725 B 726 B UMD_PROD
react-ui-events/input.production.min.js 0.0% 🔺+0.2% 1.83 KB 1.83 KB 977 B 979 B UMD_PROD
react-ui-events/scroll.production.min.js 0.0% 🔺+0.1% 2.62 KB 2.62 KB 1.14 KB 1.14 KB UMD_PROD
ReactTabbableScope-dev.js n/a n/a 0 B 1.15 KB 0 B 554 B FB_WWW_DEV
ReactTabbableScope-prod.js n/a n/a 0 B 980 B 0 B 476 B FB_WWW_PROD
react-ui-events/context-menu.development.js 0.0% +0.2% 2.48 KB 2.48 KB 954 B 956 B NODE_DEV
react-ui-events/input.development.js 0.0% +0.1% 4.33 KB 4.33 KB 1.39 KB 1.39 KB NODE_DEV
react-ui-events/scroll.development.js 0.0% +0.1% 6.11 KB 6.11 KB 1.6 KB 1.61 KB NODE_DEV
react-ui-accessibility/tab-focus.development.js n/a n/a 0 B 4.38 KB 0 B 1.21 KB NODE_DEV
react-ui-events/input.production.min.js 0.0% 🔺+0.1% 1.65 KB 1.65 KB 911 B 912 B NODE_PROD
react-ui-events/scroll.production.min.js 0.0% 🔺+0.2% 2.43 KB 2.43 KB 1.08 KB 1.09 KB NODE_PROD
react-ui-accessibility/tab-focus.production.min.js n/a n/a 0 B 1.66 KB 0 B 833 B NODE_PROD
react-ui-events/hover.development.js 0.0% +0.1% 7 KB 7 KB 1.55 KB 1.55 KB UMD_DEV
react-ui-events/press-legacy.development.js 0.0% 0.0% 20.73 KB 20.73 KB 4.83 KB 4.83 KB UMD_DEV
react-ui-events/hover.production.min.js 0.0% 🔺+0.2% 3.11 KB 3.11 KB 1.13 KB 1.13 KB UMD_PROD
react-ui-events/press-legacy.production.min.js 0.0% 🔺+0.1% 6.97 KB 6.97 KB 2.62 KB 2.63 KB UMD_PROD
TabFocus-dev.js n/a n/a 0 B 4.43 KB 0 B 1.19 KB FB_WWW_DEV
TabFocus-prod.js n/a n/a 0 B 3.53 KB 0 B 1.07 KB FB_WWW_PROD
react-ui-events/hover.development.js 0.0% +0.1% 6.81 KB 6.81 KB 1.5 KB 1.5 KB NODE_DEV
react-ui-events/press-legacy.development.js 0.0% +0.1% 20.54 KB 20.54 KB 4.78 KB 4.78 KB NODE_DEV
react-ui-accessibility/focus-table.development.js n/a n/a 0 B 6.83 KB 0 B 1.62 KB NODE_DEV
react-ui-events/hover.production.min.js 0.0% 🔺+0.2% 2.93 KB 2.93 KB 1.07 KB 1.07 KB NODE_PROD
react-ui-events/press-legacy.production.min.js 0.0% 🔺+0.1% 6.79 KB 6.79 KB 2.56 KB 2.57 KB NODE_PROD
react-ui-accessibility/focus-table.production.min.js n/a n/a 0 B 2.27 KB 0 B 992 B NODE_PROD
ReactFocusTable-prod.js n/a n/a 0 B 6.08 KB 0 B 1.39 KB FB_WWW_PROD
react-ui-events/focus.development.js 0.0% +0.1% 10.73 KB 10.73 KB 2.31 KB 2.31 KB NODE_DEV
react-ui-events/press.development.js 0.0% +0.2% 4.1 KB 4.1 KB 1.22 KB 1.23 KB NODE_DEV
react-ui-events/tap.development.js 0.0% 0.0% 16.21 KB 16.21 KB 3.6 KB 3.6 KB NODE_DEV
react-ui-events/focus.production.min.js 0.0% 🔺+0.1% 3.92 KB 3.92 KB 1.32 KB 1.32 KB NODE_PROD
react-ui-events/press.production.min.js 0.0% 🔺+0.2% 1.75 KB 1.75 KB 838 B 840 B NODE_PROD
react-ui-events/tap.production.min.js 0.0% 🔺+0.2% 5.7 KB 5.7 KB 2.22 KB 2.23 KB NODE_PROD
react-ui-events/drag.development.js 0.0% +0.1% 5.22 KB 5.22 KB 1.54 KB 1.54 KB UMD_DEV
react-ui-events/keyboard.development.js 0.0% 0.0% 6.91 KB 6.91 KB 2.39 KB 2.39 KB UMD_DEV
react-ui-events/swipe.development.js 0.0% +0.1% 5.99 KB 5.99 KB 1.62 KB 1.62 KB UMD_DEV
react-ui-events/drag.production.min.js 0.0% 🔺+0.2% 2.24 KB 2.24 KB 1.07 KB 1.07 KB UMD_PROD
react-ui-events/keyboard.production.min.js 0.0% 🔺+0.1% 2.79 KB 2.79 KB 1.39 KB 1.39 KB UMD_PROD
ReactEventsPress-dev.js +0.5% -0.5% 4.06 KB 4.08 KB 1.2 KB 1.2 KB FB_WWW_DEV
react-ui-events/swipe.production.min.js 0.0% 🔺+0.2% 2.44 KB 2.44 KB 1.1 KB 1.1 KB UMD_PROD
ReactEventsPress-prod.js 🔺+0.9% 🔺+0.1% 3.51 KB 3.54 KB 1.02 KB 1.02 KB FB_WWW_PROD
react-ui-accessibility/tabbable-scope.development.js n/a n/a 0 B 1.17 KB 0 B 578 B NODE_DEV
react-ui-events/drag.production.min.js 0.0% 🔺+0.1% 2.87 KB 2.87 KB 1.37 KB 1.38 KB NODE_PROD
react-ui-events/keyboard.production.min.js 0.0% 🔺+0.1% 2.62 KB 2.62 KB 1.34 KB 1.34 KB NODE_PROD
react-ui-events/swipe.production.min.js 0.0% 🔺+0.2% 2.26 KB 2.26 KB 1.04 KB 1.04 KB NODE_PROD
react-ui-accessibility/tabbable-scope.production.min.js n/a n/a 0 B 670 B 0 B 442 B NODE_PROD

Generated by 🚫 dangerJS against b7b3efe

@trueadm trueadm requested review from bchocho and threepointone and removed request for bchocho September 17, 2019 14:29
@necolas
Copy link
Contributor

necolas commented Sep 17, 2019

Why are the accessibility-related components being bundled together rather than separately?

@trueadm
Copy link
Contributor Author

trueadm commented Sep 17, 2019

@necolas I'll split them up. Actually, if you could review my other PR then I can land that first, as that renames the files, it makes more sense.

Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part that fixes the FB bundle's external requires looks good to me

@trueadm trueadm merged commit 7c802de into facebook:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants