-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-a11y] Add react-ui/accessibility to bundle build #16804
Conversation
Details of bundled changes.Comparing: f40ceb0...b7b3efe react-ui
|
Why are the accessibility-related components being bundled together rather than separately? |
@necolas I'll split them up. Actually, if you could review my other PR then I can land that first, as that renames the files, it makes more sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part that fixes the FB bundle's external requires looks good to me
In order to test the experimental accessibility components internally at FB, we need to be able to build the latest components so they get included in our syncs. This includes an accessibility bundle so we can test this out internally. Also, I made sure that our mappings for FB externals gets re-written appropriately, as our internal system won't recognise a
react-ui
package.